Repository navigation
feat(react-ui/theme): setup, add button, archive web-component-based packages, make ready for alpha release - #523
Open
malikarami wants to merge 16 commits into
Open
malikarami wants to merge 16 commits into
malikarami wants to merge 16 commits into
Conversation
…dules and multipage playground
malikarami
changed the title
Contributor
Contributor
Author
|
should |
amir78729
reviewed
Oct 2, 2026
| > | ||
| <span | ||
| className={styles["tapsi-row__label"]} | ||
| data-part="label" |
Member
There was a problem hiding this comment.
The data-part is actually really nice, but i have a question, how can devs select the label of the row component without confusing with another component label? i think
- we can add a
row-prefix to the part names, or - the wrapper coponetn have a
rowdata part so users can select row label using[data-part="row"][data-part="label"]
| @@ -0,0 +1 @@ | |||
| export { Row, type RowProps, type RowTextOverflow } from "./row.tsx"; | |||
Member
There was a problem hiding this comment.
I think exporting RowTextOverflow is not necessary. Devs can have access to it via the RowProps type
amir78729
reviewed
Oct 2, 2026
Comment on lines
+115
to
+116
| loading && styles["tapsi-button--loading"], | ||
| fullWidth && styles["tapsi-button--full-width"], |
Member
There was a problem hiding this comment.
NIT: i prefer passing data-fullwidth and data-loading as attribures and in css file use [data-fullwidth] instead of defining classes
| }, | ||
| "dependencies": { | ||
| "@tapsioss/theme": "workspace:*", | ||
| "@tapsioss/theme": "0.8.0", |
| "name": "@tapsioss/react-components", | ||
| "description": "Collection of React components for the Tapsi Design System UI.", | ||
| "version": "0.17.7", | ||
| "private": true, |
Member
There was a problem hiding this comment.
isn't this package going to be published?
… the migration phase
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.