Allow selecting same frequency plan multiple times for gateway registration - #8042
Open
PavelJankoski wants to merge 1 commit into
Open
PavelJankoski wants to merge 1 commit into
PavelJankoski wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation preserves same-band filtering and includes end-to-end regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Allows duplicate gateway frequency plans while retaining same-band filtering.
Changes:
- Separates same-band filtering from distinct-option filtering.
- Enables duplicate plans in gateway registration and settings.
- Adds Cypress coverage and a changelog entry.
| File | Description |
|---|---|
pkg/webui/jsconfig.json |
Enables React JSX tooling. |
pkg/webui/console/containers/freq-plans-select/gs-frequency-plan-select.js |
Permits duplicate plans. |
pkg/webui/components/key-value-map/entry.js |
Preserves tag filtering independently. |
cypress/e2e/console/gateways/edit.spec.js |
Tests duplicate plan persistence. |
CHANGELOG.md |
Documents the fix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
PavelJankoski
requested review from
ryaplots
and removed request for
mjamescompton
September 30, 2026 11:56
PavelJankoski
force-pushed
the
fix/8041-duplicate-frequency-plans
branch
from
September 30, 2026 13:28
d38dd51 to
9bf961d
Compare
PavelJankoski
force-pushed
the
fix/8041-duplicate-frequency-plans
branch
from
September 30, 2026 15:43
9bf961d to
a293e94
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
References #8041
Changes
Testing
Steps
Results
Checklist
README.mdfor the chosen target branch.CHANGELOG.md.CONTRIBUTING.md, there are no fixup commits left.