Skip to content

Allow selecting same frequency plan multiple times for gateway registration - #8042

Open
PavelJankoski wants to merge 1 commit into
v3.37from
fix/8041-duplicate-frequency-plans
Open

PavelJankoski wants to merge 1 commit into
v3.37from
fix/8041-duplicate-frequency-plans

Conversation

@PavelJankoski

Copy link
Copy Markdown
Contributor

Summary

References #8041

Changes

  • Allow selecting same frequency plans and not only distinct options on the gateway registration form.

Testing

Steps
  1. Login to console.
  2. Go to Gateways tab.
  3. Click register gateway button.
  4. Try to select multiple same frequency plans.
  5. Submit form.
Results
image

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@PavelJankoski
PavelJankoski requested a balanced review from Copilot September 30, 2026 11:51
@PavelJankoski PavelJankoski self-assigned this Sep 30, 2026
@PavelJankoski
PavelJankoski requested a review from a team as a code owner September 30, 2026 11:51
@github-actions github-actions Bot added the ui/web This is related to a web interface label Sep 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused implementation preserves same-band filtering and includes end-to-end regression coverage.

Review effort: Balanced
Findings: None

What changed in this PR

Allows duplicate gateway frequency plans while retaining same-band filtering.

Changes:

  • Separates same-band filtering from distinct-option filtering.
  • Enables duplicate plans in gateway registration and settings.
  • Adds Cypress coverage and a changelog entry.
File Description
pkg/​webui/​jsconfig.json Enables React JSX tooling.
pkg/​webui/​console/​containers/​freq-plans-select/​gs-frequency-plan-select.js Permits duplicate plans.
pkg/​webui/​components/​key-value-map/​entry.js Preserves tag filtering independently.
cypress/​e2e/​console/​gateways/​edit.spec.js Tests duplicate plan persistence.
CHANGELOG.md Documents the fix.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@PavelJankoski
PavelJankoski requested review from ryaplots and removed request for mjamescompton September 30, 2026 11:56
@PavelJankoski
PavelJankoski force-pushed the fix/8041-duplicate-frequency-plans branch from d38dd51 to 9bf961d Compare September 30, 2026 13:28
@PavelJankoski
PavelJankoski force-pushed the fix/8041-duplicate-frequency-plans branch from 9bf961d to a293e94 Compare September 30, 2026 15:43

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui/web This is related to a web interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants