Skip to content

Fix storybook - #8043

Open
PavelJankoski wants to merge 1 commit into
v3.37from
fix/storybook
Open

PavelJankoski wants to merge 1 commit into
v3.37from
fix/storybook

Conversation

@PavelJankoski

@PavelJankoski PavelJankoski commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

I realized colors were not visible on the components when running storybook. Also bunch of stories were crushing because of typos or different types of errors.

image image image image image

Changes

  • Added light theme by default on the html tag.
  • Fix typos and errors.
  • Fix icon and header old usage.

Testing

Steps

Run storybook and go through the components

Results

Storybook should run correctly and show no errors.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@PavelJankoski
PavelJankoski requested a balanced review from Copilot September 30, 2026 12:35
@PavelJankoski PavelJankoski self-assigned this Sep 30, 2026
@PavelJankoski
PavelJankoski requested a review from a team as a code owner September 30, 2026 12:35
@PavelJankoski
PavelJankoski requested review from mjamescompton and removed request for mjamescompton September 30, 2026 12:35
@github-actions github-actions Bot added the ui/web This is related to a web interface label Sep 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused corrections are consistent with existing exports and theme infrastructure, with no unresolved issues found.

Review effort: Balanced
Findings: None

What changed in this PR

Fixes Storybook rendering failures and restores theme colors.

Changes:

  • Applies the light theme to Storybook.
  • Corrects icon and date-time component references.
  • Fixes progress percentage and ETA validation.
File Description
config/​storybook/​preview.js Enables Storybook’s light theme.
pkg/​webui/​components/​progress-bar/​index.js Corrects status formatting and ETA handling.
pkg/​webui/​components/​stepper/​step/​index.js Fixes success icon reference.
pkg/​webui/​components/​submit-bar/​story.js Fixes story icon references.
pkg/​webui/​lib/​components/​date-time/​story.js Uses the supported relative date-time API.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui/web This is related to a web interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants