Repository navigation
perf: cut get-impacted-targets --depEdgesFile CPU by about half - #621
Merged
tinder-maxwellelliott merged 1 commit intoNov 4, 2026
Merged
Conversation
maxwellE
commented
Nov 4, 2026
Contributor
- Sort the distance result on a rank computed once per label instead of a key closure that looked the label up in both maps and cloned it on every comparison.
- Walk distances over borrowed labels: the memo, cycle guard and dependency lists no longer allocate a String per visit.
- Build the hash and dep-edges maps in one bulk pass from the (sorted) entries instead of one tree search per insert.
- Skip the second hash diff and the full copy of the starting hashes when the module graph is unchanged: no module-only targets exist then.
- Sort the distance result on a rank computed once per label instead of a key closure that looked the label up in both maps and cloned it on every comparison. - Walk distances over borrowed labels: the memo, cycle guard and dependency lists no longer allocate a String per visit. - Build the hash and dep-edges maps in one bulk pass from the (sorted) entries instead of one tree search per insert. - Skip the second hash diff and the full copy of the starting hashes when the module graph is unchanged: no module-only targets exist then. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KJs3XyDHGXocPX8AFo8rZm
tinder-maxwellelliott
marked this pull request as ready for review
November 4, 2026 13:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.