Repository navigation
Unify model identity and catalog revalidation - #1728
Merged
luokerenx4 merged 6 commits intoOct 6, 2026
Merged
Conversation
|
@ZenAlexa is attempting to deploy a commit to the luokerenx4's Team Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Oct 1, 2026
ZenAlexa
marked this pull request as ready for review
October 1, 2026 22:46
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Model choices currently mix raw identifiers, duplicate provider labels, reasoning summaries, and catalog metadata across launch menus, credentials, sessions, and issues. This PR gives those surfaces one model identity and keeps catalog discovery aligned with the active credential or runtime.
This is the model boundary extracted from #1704. The base is
devat4813c1b89.What changed
ModelIdentityand one display-name and manufacturer resolver. Known model families use a manufacturer logo and readable model name. Catalog labels remain the primary display source. Custom identifiers retain their exact value.Review boundary
Navigation density, shared control replacement, themes, trading behavior, backend routing, and bundled model version policy are outside this PR. Catalog freshness uses the existing discovery API and its refresh status.
Default identity and compact summaries
Commit
20f5e20a6gives the runtime-default row the same identity layout as named models. A resolved default keeps its manufacturer icon and name, with the Default annotation in the trailing column. Compact summaries truncate long names; selectable options retain their full wrapped label and exact configured ID.Commit
e8b56ce4fsynchronizes this boundary with upstream4813c1b89. The shared-control PR owns the parent columns and cascading gap.Catalog-refresh boundary fix
Commit
108135522tracks the active suggestion by its model ID and derives its position from the current catalog. Catalog shrinkage and replacement now clear invalid active descendants. Reordering preserves the same model. Enter resolves the current option, and Escape closes an empty result list.Checked the actual credential catalog consumer through refresh, list shrinkage, reordering, clearing, restoration, keyboard wrapping, and custom identifier entry. The focused catalog refresh completed without an Enter exception. The patch changes one existing file, with 19 additions and 20 deletions.
The composed integration retains the shared Base UI Autocomplete from #1730. That component owns active-option lifecycle after the control migration.
Related PRs and integration
Each branch targets
devand includes upstream4813c1b89. Each branch builds independently. Shared consumers overlap. Suggested merge order: #1730, #1728, #1729. Integrate each subsequent branch with the merged changes and preserve each component's presentation owner.Composed integration reference
eff62db08contains all three updated PR heads and the shared-file resolutions. The existing galleries below were captured on 2026-10-02 from integration5eae22a85, using supplied demo data. Desktop captures use 1280 × 720; narrow captures use 390 × 844. Each caption identifies the view and state.Current model menu
The three current-value fields share the same left origin and line height. The child menu keeps an 8px gap from its parent after entry. The parent remains 130px high. Manufacturer icons and readable names keep the catalog compact.
Verification
The current update was checked on 2026-10-02 against upstream
devat4813c1b89.git diff --checkpassed.Review ID preservation and catalog request ownership first, then the display consumers. The integration reference includes the compact-workspace changes at those consumers.
Menu transitions and keyboard focus need the running build for review. Screenshots record their resting geometry.
GitHub
clean-buildpassed on this update. Vercel preview deployment requires authorization from the repository’s Vercel team.