Repository navigation
fix(ui): clear stale navigation highlights when opening Chat - #1746
Draft
luokerenx4 wants to merge 1 commit into
Draft
luokerenx4 wants to merge 1 commit into
luokerenx4 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking Issues and then Chat leaves both navigation entries highlighted. This Draft fixes that current-dev regression only; layout and navigation destinations keep their existing behavior. Related: #1514.
flowchart LR subgraph Before A[Click Issues] --> B[Stored sidebar selects Issues] B --> C[Click Chat] C --> D[Focused tab selects Chat] B --> E[FAIL: Issues stays highlighted] D --> F[Chat also highlights] end subgraph After G[Click any destination] --> H[Existing focused tab owner] H --> I[Existing tab to section mapping] I --> J[Only the current destination highlights] endThe rail now derives selection from the focused tab, as the Harness rows already do. The existing URL adopter's mapping moves unchanged into the shared tab types module and is reused; no new state or navigation abstraction. The old persisted sidebar field remains for existing callers, but it no longer controls rail highlighting. This intentionally bounds the fix rather than migrating unrelated stored UI state.
Interaction choice: keep the current routes and controls and unify selection ownership, instead of adding more setters to every navigation path. Desktop, compact rail and mobile drawer geometry are unchanged.
aria-currentfollows the same selected destination as the highlight. No new primitive.Validation:
/issues: Issues → Chat yielded two current-page entries.Overlap: #1440 is owned by the other batch; its navigation test should preserve this focused-tab ownership. Open #1730 changes ActivityBar styling but its inspected diff retains the broken selectedSidebar condition, so it does not cover this fix. Integrate that shared line when accepting either PR. #1051 terminal-theme work is untouched.