Repository navigation
fix: replace TODO with nginx:alpine image in svc-new.sh - #141
dsaikou618 wants to merge 5 commits into
Conversation
|
The nginx:alpine default (53e5c11) is a clean, correct fix for the TODO. The other commit on this branch (17d5906, "config.sh enhancements for multi-user support") is not - it appends a hardcoded personal [user] block to the end of the shared, tracked shared/stow/git/.gitconfig: Git config takes the last matching value for a scalar key, so this literal block overrides the [include] path = ~/.gitconfig.local line above it for every single person who clones this repo and stows git - every commit from every user gets authored as this hardcoded identity instead of their own. It also commits a real name and GitHub-linked email into a shared tracked file, the opposite of what the profile system is supposed to keep local. That commit also duplicates/diverges from the profile.env and config.sh changes already in #139 rather than building on them - probably worth dropping entirely and rebasing just the nginx fix onto master directly. This PR is also stacked on #139/#140's unmerged branches, so the diff includes their open issues too. |
Not mergeable as it stands, and the reason is the branch point, not the ideaThe profiles feature is good work. The problem is that this branch was cut from an older 1. It replaces the repo owner's git identity with yours. from the top and gains at the bottom. Every machine installing these dotfiles would then commit as you. This also defeats the feature's own purpose: identity is exactly what should come from 2. It removes the NTNU setup. 3. It deletes the STM32 filetype mapping in vim.filetype.add({ pattern = { [".*%.c[1-6]"] = "c" } })That is live coursework config for 4. It reverts Separately, Also: three PRs, one body of work#139, #140 and #141 all share the same two base commits ( Closing all three in favour of one re-cut branch. What a re-cut should containBranch from current
Leave untouched: One open question that needs the repo owner's answer before the re-cut, which is also why I am not synthesising the replacement PR myself: Generated by Claude Code |
Replace the TODO placeholder with nginx:alpine as the default image in svc-new.sh