Skip to content

JTech theme: a post's Reply is an icon like the rest on a phone - #372

Merged
TripleU613 merged 2 commits into
mainfrom
claude/remove-disqualified-ballot-h5nhiv
Nov 3, 2026
Merged

TripleU613 merged 2 commits into
mainfrom
claude/remove-disqualified-ballot-h5nhiv

Conversation

@TripleU613

@TripleU613 TripleU613 commented Nov 2, 2026 •

Copy link
Copy Markdown
Owner

Summary

Reply in each post's row of buttons has an outline (jt-post-chrome.scss), which on a computer goes round the word Reply. On a phone the word is hidden, so Reply was the one boxed icon in the row and looked out of place. On phones the outline is now transparent, so Reply is an arrow like the icons beside it, evenly spaced with them. Computers keep the outline.

The topic footer's Reply is unchanged. An earlier version of this PR resized it; that's been dropped.

Affected module(s)

  • Moderator tools
  • Mini-mod
  • Dislike
  • Disteleplus
  • REQ-PM
  • Mod elections
  • Dumbcourse
  • Smart search
  • Pop-ups
  • Another SMTP
  • Translator tweaks
  • JTech theme
  • Shared (plugin.rb, settings, locales, docs, lint/CI)

Test plan

  • New jtech_theme_part3_spec.rb examples:
    • on a 390px phone, a post's Reply has a transparent border and is the same size as Copy link beside it
    • on a computer, Reply keeps its outline
  • Before and after screenshots of a topic at 390px: Reply went from a boxed icon to a plain arrow in line with the others.
  • pnpm lint:theme clean; rubocop and stree clean.

Checklist

  • pnpm lint is clean
  • bundle exec rubocop is clean
  • New / changed settings have entries in config/locales/server.en.yml or client.en.yml (no settings changed)
  • New / changed behavior has a spec (a bug fix has one that fails without it)
  • Follows the repository rules: no access past core, visibility checked, nothing core already does
  • No Ruby file references a non-existent setting name

🤖 Generated with Claude Code

https://claude.ai/code/session_01FGn9A1EjvUZh9u1zSaCHPh

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T00:08:49.651500Z d531cad New commits
🔒 Security Review ✅ Completed 2026-11-03T00:09:12.349693Z d531cad New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Reply in each post's row of buttons has an outline, which on a computer
goes round its word. On a phone it has no word, so it was the one boxed
icon in the row and looked out of place. The outline is now transparent
there; computers keep it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FGn9A1EjvUZh9u1zSaCHPh
@TripleU613
TripleU613 force-pushed the claude/remove-disqualified-ballot-h5nhiv branch from 7a8ae55 to 4273ca4 Compare November 2, 2026 23:58
@TripleU613 TripleU613 changed the title JTech theme: a phone's Reply under a topic sits level with the icons JTech theme: a post's Reply is an icon like the rest on a phone Nov 2, 2026
Every CI job that installs packages failed on main after the batch of
dependabot merges, and each fix uncovered the next:
- pnpm install --frozen-lockfile refused: package.json still asked for
  @glint/ember-tsc 1.13.1 while the lockfile had the bump's 1.14.2, and
  the lockfile pointed lint-configs at a postcss it no longer listed.
  package.json now asks for 1.14.2 and the lockfile is regenerated with
  the repo's pnpm 10.28.0.
- lint-configs 3.9.1 brought discourse/truth-helpers-keywords, which
  swaps imported eq/and/gt for Ember's built-in keywords. They're in the
  newest cores only and Glint can't type-check them, so it's off, like
  the other rules here that assume the newest core. Its other new rules
  only reorder attributes and a decorator in the slow-mode modal.
- lucide-static 1.65 changed two icons, so the theme's sprite is
  regenerated (pnpm theme:icons).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FGn9A1EjvUZh9u1zSaCHPh

Copy link
Copy Markdown
Owner Author

The first run's scripts, dumbcourse, theme and ci / linting failures weren't from this PR. main is red the same way since the November dependabot merges (the Discourse Plugin run on e29c9e6 failed), and no fix was open, so I've added one here as its own commit, d531cad:

Locally, pnpm install --frozen-lockfile and every pnpm lint task pass from a clean ESLint cache.


Generated by Claude Code

@TripleU613
TripleU613 merged commit 8158c27 into main Nov 3, 2026
10 checks passed
@TripleU613
TripleU613 deleted the claude/remove-disqualified-ballot-h5nhiv branch November 3, 2026 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants