Repository navigation
JTech theme: a post's Reply is an icon like the rest on a phone - #372
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reply in each post's row of buttons has an outline, which on a computer goes round its word. On a phone it has no word, so it was the one boxed icon in the row and looked out of place. The outline is now transparent there; computers keep it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FGn9A1EjvUZh9u1zSaCHPh
TripleU613
force-pushed
the
claude/remove-disqualified-ballot-h5nhiv
branch
from
November 2, 2026 23:58
7a8ae55 to
4273ca4
Compare
Every CI job that installs packages failed on main after the batch of dependabot merges, and each fix uncovered the next: - pnpm install --frozen-lockfile refused: package.json still asked for @glint/ember-tsc 1.13.1 while the lockfile had the bump's 1.14.2, and the lockfile pointed lint-configs at a postcss it no longer listed. package.json now asks for 1.14.2 and the lockfile is regenerated with the repo's pnpm 10.28.0. - lint-configs 3.9.1 brought discourse/truth-helpers-keywords, which swaps imported eq/and/gt for Ember's built-in keywords. They're in the newest cores only and Glint can't type-check them, so it's off, like the other rules here that assume the newest core. Its other new rules only reorder attributes and a decorator in the slow-mode modal. - lucide-static 1.65 changed two icons, so the theme's sprite is regenerated (pnpm theme:icons). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FGn9A1EjvUZh9u1zSaCHPh
Owner
Author
|
The first run's
Locally, Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reply in each post's row of buttons has an outline (
jt-post-chrome.scss), which on a computer goes round the word Reply. On a phone the word is hidden, so Reply was the one boxed icon in the row and looked out of place. On phones the outline is now transparent, so Reply is an arrow like the icons beside it, evenly spaced with them. Computers keep the outline.The topic footer's Reply is unchanged. An earlier version of this PR resized it; that's been dropped.
Affected module(s)
Test plan
jtech_theme_part3_spec.rbexamples:pnpm lint:themeclean; rubocop and stree clean.Checklist
pnpm lintis cleanbundle exec rubocopis cleanconfig/locales/server.en.ymlorclient.en.yml(no settings changed)🤖 Generated with Claude Code
https://claude.ai/code/session_01FGn9A1EjvUZh9u1zSaCHPh