Skip to content

chore(deps): consume the event store fork the adapter is written against - #112

Merged
yordis merged 2 commits into
mainfrom
yordis/chore-consume-eventstore-fork
Sep 24, 2026
Merged

yordis merged 2 commits into
mainfrom
yordis/chore-consume-eventstore-fork

Conversation

@yordis

@yordis yordis commented Sep 24, 2026 •

Copy link
Copy Markdown
Member
  • Resolving :eventstore by name from Hex pulled a different event store than the one this adapter is written for, so the adapter was compiled and tested against code that does not ship with it. The subscription fixes it depends on were never exercised.
  • The advisories the tree was carrying all had published fixes available, and leaving them in place meant every consumer inherited them.

Replaces #111, which carried a commit type the repository does not allow.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

…tten against

The adapter's behaviour is decided by this fork, so resolving the name from Hex tested a different event store than the one it ships with.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…ying

Every advisory in the tree had a published fix, and the decimal one needed a newer ecto first before its major release could be taken.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor

cursor Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
Swaps the optional Event Store implementation and bumps several database-related transitive deps, which affects integration tests and anyone relying on the optional :eventstore dep, though no application source files change in this PR.

Overview
Pins the optional :eventstore dependency to the TrogonStack fork (commanded_eventstore v1.4.9) instead of resolving :eventstore from Hex, so builds and eventstore_adapter tests run against the same Event Store the adapter targets (including subscription behavior that Hex’s package did not provide).

mix.lock is refreshed with that git dependency and newer transitive versions (e.g. Ecto 3.14, decimal 3, postgrex, db_connection, jason, telemetry) that come along with the updated tree and address previously outstanding advisories.

Reviewed by Cursor Bugbot for commit f38efb6. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 38 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 0b9361ae-4035-4a31-a96b-cf27044e4a67

📥 Commits

Reviewing files that changed from the base of the PR and between a1dbd95 and f38efb6.

⛔ Files ignored due to path filters (1)
  • mix.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • mix.exs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yordis
yordis merged commit a1ce1aa into main Sep 24, 2026
6 of 8 checks passed
@yordis
yordis deleted the yordis/chore-consume-eventstore-fork branch September 24, 2026 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant