Skip to content

CDA-125: Bulk vertical datum info retrieval endpoint - #1846

Open
zack-rma wants to merge 23 commits into
USACE:developfrom
zack-rma:featrue/vertical-datum-get-all
Open

zack-rma wants to merge 23 commits into
USACE:developfrom
zack-rma:featrue/vertical-datum-get-all

Conversation

@zack-rma

Copy link
Copy Markdown
Collaborator

Summary

Implementation of vertical datum info bulk retrieval endpoint.

Related Issue

Closes #1730

Validation

Integration testing included.

Checklist

  • AI tools used

@zack-rma
zack-rma marked this pull request as ready for review September 21, 2026 20:17
@zack-rma

Copy link
Copy Markdown
Collaborator Author

It would seem the Minimum Schema annotation is being ignored due to the cwms_db_change_log table being incorrectly populated with version 99.99.99.

The content of the populate_cwms_db_change_log.sql file in the cwms-database (generated file) includes:

J:\Code\IdeaProjects\cwms-database\schema\extract_version_update_info.py:45: SyntaxWarning: invalid escape sequence '\d'
  if os.path.isdir(pn) and re.match("\d+_\d+_\d+", os.path.split(pn)[-1]) :

I believe other usages of the minimum schema annotation have reached the point where the version specified is lower than the minimum schema used in the integration tests, which would explain why no other similar tests are failing.

@zack-rma

Copy link
Copy Markdown
Collaborator Author

@MikeNeilson

Copy link
Copy Markdown
Contributor

I don't believe that particular script is used anymore, in the containers it's derived from the pom.xml and when running the update scripts the script just sets it.

the latest-dev variant intentionally sets the version 99.99.99

There's additional logic in the versioned releases to establish the correct version.
Which then gets ignored in our cloud environments due to well, various issues.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Endpoint to Get Vertical Datums and Offsets at All Locations

2 participants