Skip to content

CDA-132: Blob upload support via Swagger UI - #1957

Merged
rma-bryson merged 17 commits into
USACE:developfrom
zack-rma:feature/blob-upload
Oct 29, 2026
Merged

rma-bryson merged 17 commits into
USACE:developfrom
zack-rma:feature/blob-upload

Conversation

@zack-rma

Copy link
Copy Markdown
Collaborator

Summary

Initial implementation of BlobControllerV2 with multipart form data support.

Based on code by @rripken in https://github.com/rma-rripken/cwms-data-api/tree/feature/blob_post_upload

Related Issue

Closes #1718

Validation

Integration tests included.

Checklist

  • AI tools used

@zack-rma
zack-rma marked this pull request as ready for review September 25, 2026 19:35
@zack-rma
zack-rma requested a review from rma-bryson September 25, 2026 19:35
Comment thread cwms-data-api/src/main/java/cwms/cda/api/blob/BlobControllerV2.java Outdated
Comment thread cwms-data-api/src/main/java/cwms/cda/api/blob/BlobControllerV2.java Outdated
Comment thread cwms-data-api/src/main/java/cwms/cda/api/blob/BlobControllerV2.java Outdated
Comment thread cwms-data-api/src/main/java/cwms/cda/api/blob/BlobControllerV2.java Outdated
@zack-rma
zack-rma requested a review from rma-bryson September 30, 2026 21:37
Comment thread cwms-data-api/src/main/java/cwms/cda/api/blob/BlobControllerV2.java Outdated
Comment thread cwms-data-api/src/main/java/cwms/cda/api/blob/BlobControllerV2.java Outdated
@zack-rma

zack-rma commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

Here are a few screenshots of the updated endpoints in the Swagger UI:

image image image

rma-bryson
rma-bryson previously approved these changes Oct 1, 2026

@MikeNeilson MikeNeilson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zack-rma does every individual extra variable need to be it's own multipart section or could there be a single json or form encoded multipart block?

@zack-rma

zack-rma commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator Author

@zack-rma does every individual extra variable need to be it's own multipart section or could there be a single json or form encoded multipart block?

The Swagger UI represents the multipart block as individual sections based on the Blob DTO.

@MikeNeilson Are you referring to additional variables in the DTO?

@MikeNeilson

Copy link
Copy Markdown
Contributor

@zack-rma does every individual extra variable need to be it's own multipart section or could there be a single json or form encoded multipart block?

The Swagger UI represents the multipart block as individual sections based on the Blob DTO.

@MikeNeilson Are you referring to additional variables in the DTO?

Now that I read it again, I think I was just misunderstanding how it was rendered.

@@ -1,5 +1,5 @@
#Mon Sep 14 14:33:46 UTC 2026
#Thu Sep 24 11:42:39 PDT 2026
USER_LISTS=true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... not you're problem... we really need to figure out how to not have this file get updated every time we do a build.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this file has been an annoyance.

I've reverted the changes made by my build

@rma-bryson
rma-bryson merged commit fc341f4 into USACE:develop Oct 29, 2026
11 checks passed
@zack-rma
zack-rma deleted the feature/blob-upload branch October 29, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add file-upload field to Blob POST end-point

3 participants