Skip to content

add full lock metadata to lock catalog API - #2009

Open
adamkorynta wants to merge 1 commit into
developfrom
bugfix/lock_catalog_metadata
Open

adamkorynta wants to merge 1 commit into
developfrom
bugfix/lock_catalog_metadata

Conversation

@adamkorynta

Copy link
Copy Markdown
Member

default unit system to SI for backwards compatibility

Summary

Lock getAll endpoint returned numerical metadata as zeroes due to using primitives in the DTO. The catalog should just return the actual values.

Related Issue

Closes #2008

Validation

Integration testing

Checklist

  • AI tools used

default unit system to SI for backwards compatibility

@rma-bryson rma-bryson left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can those fields be undefined? Wondering if we should just make those Double or OptionalDouble rather than primitives in the Lock DTO

@adamkorynta

Copy link
Copy Markdown
Member Author

Can those fields be undefined? Wondering if we should just make those Double or OptionalDouble rather than primitives in the Lock DTO

That would make the API non-backwards compatible. Maybe in a new version?

@rma-bryson

Copy link
Copy Markdown
Collaborator

Can those fields be undefined? Wondering if we should just make those Double or OptionalDouble rather than primitives in the Lock DTO

That would make the API non-backwards compatible. Maybe in a new version?

yes, iff the db supports those being undefined.

@adamkorynta

Copy link
Copy Markdown
Member Author

Can those fields be undefined? Wondering if we should just make those Double or OptionalDouble rather than primitives in the Lock DTO

That would make the API non-backwards compatible. Maybe in a new version?

yes, iff the db supports those being undefined.

yeah it does. The scope of this work will be for the current endpoint version, not making a new one

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: /locks getAll endpoint incorrectly returns lock metadata as 0.0

3 participants