Skip to content

fix(apollo-vertex): keep the user token out of solution-test trigger bodies - #1434

Merged
RobinMennens-UiPath merged 1 commit into
mainfrom
feat/solution-tests-no-body-token
Oct 27, 2026
Merged

RobinMennens-UiPath merged 1 commit into
mainfrom
feat/solution-tests-no-body-token

Conversation

@RobinMennens-UiPath

Copy link
Copy Markdown
Contributor

The solution-tests write actions copied the user's bearer token into the HTTP trigger's request body. Orchestrator stores that body as the job's input arguments, which anyone with Jobs.View in the folder can read. create-actions.ts now sends the token in the Authorization header only.

The FINS backend gets the caller from the job's Orchestrator creator instead: UiPath/fins-vertical-solution#1502. FINS is the only consumer of solution-tests, so the old body fields go without a compatibility path. The file matches the FINS webapps' copies byte for byte.

Checked with tsc --noEmit, oxlint --type-aware registry/solution-tests and biome format in packages/apollo-vertex.

🤖 Generated with Claude Code

https://claude.ai/code/session_01VQA1xEsDwn4t2UBBRpTroi

…bodies

The trigger body becomes the job's input arguments, which anyone with
Jobs.View in the folder can read. Send the bearer token in the
Authorization header only; the backend reads the caller from the job's
creator (UiPath/fins-vertical-solution#1502).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VQA1xEsDwn4t2UBBRpTroi
Copilot AI balanced review requested due to automatic review settings October 21, 2026 14:36
@RobinMennens-UiPath
RobinMennens-UiPath requested a review from a team as a code owner October 21, 2026 14:36
@github-actions
github-actions Bot temporarily deployed to preview/apollo-docs October 21, 2026 14:36 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-landing October 21, 2026 14:36 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-vertex October 21, 2026 14:36 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-design October 21, 2026 14:36 Destroyed
@github-actions github-actions Bot added the size:S 10-29 changed lines. label Oct 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Compatibility and authorization depend on the linked FINS backend change, which requires human verification.

No open issues 🎉

What changed in this PR

Prevents solution-test actions from exposing bearer tokens through Orchestrator job input arguments.

Changes:

  • Keeps bearer tokens exclusively in the Authorization header.
  • Removes body authentication fields, relying on the coordinated FINS backend change to identify callers.
File Description
packages/​apollo-vertex/​registry/​solution-tests/​create-actions.ts Removes token-bearing request fields and documents header-only authentication.

Review effort: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

Dependency License Review

  • ✅ 1957 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1721
ISC 91
Apache-2.0 57
BSD-3-Clause 28
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
CC0-1.0 4
MIT-0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.3.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage + size by package

Per-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.

Package Coverage New-line coverage Packed (gzip) Unpacked vs main
@uipath/apollo-core — — — — —
@uipath/apollo-react — — — — —
@uipath/apollo-ui-icons — — — — —
@uipath/apollo-vertex 85.5% — (11 untracked) 336.8 KB 1.88 MB −4 B
@uipath/apollo-wind — — — — —
@uipath/ap-chat — — — — —

"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.

@github-actions

Copy link
Copy Markdown
Contributor

Storybook visual diff

✅ No stories are affected by this PR's changes; nothing to compare. Logs

Updated (PT): Oct 21, 2026, 07:45:25 AM

@RobinMennens-UiPath RobinMennens-UiPath self-assigned this Oct 22, 2026
@RobinMennens-UiPath
RobinMennens-UiPath merged commit 36f3ceb into main Oct 27, 2026
39 of 40 checks passed
@RobinMennens-UiPath
RobinMennens-UiPath deleted the feat/solution-tests-no-body-token branch October 27, 2026 09:02

This branch was successfully deployed

No deployments
preview/apollo-design — b5fdf0ef Deployed Oct 21, 2026 by github-actions[bot]
preview/apollo-docs — b5fdf0ef Deployed Oct 21, 2026 by github-actions[bot]
preview/apollo-landing — b5fdf0ef Deployed Oct 21, 2026 by github-actions[bot]
preview/apollo-vertex — b5fdf0ef Deployed Oct 21, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:apollo-vertex size:S 10-29 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants