Repository navigation
fix(apollo-wind): build the field header actions on the 3xs Button [MST-16146] - #1456
BenGSchulz wants to merge 1 commit into
Conversation
Dependency License Review
License distribution
Excluded packages
|
Storybook visual diff⏭️ Skipped: the apollo-design preview deployment did not succeed, so no comparison ran. Logs Updated (PT): Oct 26, 2026, 11:35:19 AM |
📊 Coverage + size by packagePer-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.
"Coverage" is each package's own |
…ST-16146] FormFieldHeader's row is `min-h-6`, the height of a `3xs` Button, but the AI assist and Insert variable actions, and QuickFormField's field type and compact Required triggers, were hand-built 28px buttons. Every header that carried them grew to 28px, and a layout that hid them had to restate that height to keep the row still. They are now ghost `3xs` Buttons in the muted tone of the field's other icon buttons, with 12px icons, so the header is the 24px row it is meant to be. The 3xs padding is already the collapsed padding, so the collapsed padding override goes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
da91ce2 to
b05d383
Compare
Summary
FormFieldHeader's row ismin-h-6, the height of a3xsButton, but the header actions were hand-built 28px buttons, so every header that carried them grew to 28px (MST-16146).AiAssistActionandInsertVariableAction, and QuickFormField's field type and compact Required triggers, are now ghostsize="3xs"Buttons sharing oneFIELD_ACTION_CLASS, with 12px icons.FormFieldHeaderexpects. Collapsed actions are 24×24.COLLAPSED_ICON_PADDINGis gone, as the3xspadding already matches it.COLLAPSED_ONLYshows asflex, so the compact Required trigger's wrapper adds no line box.Decisions worth a look
3xs12px medium. This also applies toforms/field-actionsand the form designer, which use the same two actions.FieldMenu:text-muted-foregroundwith anaccenthover, instead offoreground-subtlewith asurface-overlayhover.Demo
Also fixes a jump / inconsistent header heights when removing actions
Before:
Screen.Recording.2026-10-22.at.3.11.31.PM.mov
After:
Screen.Recording.2026-10-22.at.3.12.42.PM.mov
Test plan
Stack
🤖 Generated with Claude Code