Repository navigation
fix(apollo-wind): design-time Text area starts one line and grows with its content - #1460
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The native textarea still defaults to two rows, so lowering its minimum height alone does not achieve the intended one-line initial height.
1 open issue
What changed in this PR
This PR adjusts the design-time QuickFormField textarea to start at one line while retaining content-driven growth up to eight lines.
Changes:
- Lowers the textarea’s minimum row count from three to one.
- Adds a regression test for the one-row minimum height.
| File | Description |
|---|---|
packages/apollo-wind/src/components/ui/quick-form-field/quick-form-field.tsx |
Updates the minimum row count and sizing comment. |
packages/apollo-wind/src/components/ui/quick-form-field/quick-form-field.divergence.test.tsx |
Tests the textarea’s one-row minimum height in jsdom. |
Review effort: Balanced
Dependency License Review
License distribution
Excluded packages
|
Sahil-Wakode
changed the title
github-actions
Bot
added
size:M
📊 Coverage + size by packagePer-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.
"Coverage" is each package's own |
Storybook visual diff⏭️ Skipped: the apollo-design preview deployment did not succeed, so no comparison ran. Logs Updated (PT): Oct 26, 2026, 10:29:25 PM |
Sahil-Wakode
changed the title
At design time every field type is the same one-line control; a Text area now starts at one line too and grows with its content up to eight lines. The multi-line box is for the runtime form, not the authoring row.
…gn time Design time uses the same one-line control for every field type, so a Text area no longer grows: floor and ceiling are both one row, and it leaves the grow layout. Content scrolls inside the box; it stays a textarea so line breaks in a saved value survive.
A MetadataForm textarea started at four rows and scrolled past them. It now starts at the same height (minRows, else rows, else 4) and grows with its content up to maxRows (new, default 8) before scrolling. The ceiling never sits below the floor, so a field asking for 10 rows still starts at 10.
Review fixes:
- rows={1}: a native textarea's intrinsic height is two rows.
- Wrap the Text area so the group keeps its row height and centring:
a direct-child textarea switches it to h-auto, top-aligned. Measured
in a real browser, the Text area box is now exactly a Text box (36px
core, 40px future) and stays that height with three lines of content.
- schema-serializer keeps maxRows beside minRows.
A form textarea now starts at one row (rows/minRows still honoured) and grows with its content up to eight. Sets the native rows too, since a textarea's intrinsic height is two rows. Measured in a real browser: 38px empty, 178px at the eight-row cap.
The drag handle already lets a reviewer make the box as tall as they need, so the eight-row auto-grow ceiling, the new maxRows option and its serializer support are removed. A form textarea starts at one row and keeps its resize handle.
Design time needs only rows={1}: min/maxRows switch on auto-sizing a
fixed box never uses. Runtime inlines the helper as one rows value used
for both rows and minRows.
Starts at one row and resizes to the content it is given, up to eight rows, then scrolls. The drag handle still makes it bigger beyond that.
…row with content Per review: runtime field-control is left as it was on main, and the design-time text area starts at one line like a text field, then grows with its content.
|
@Sahil-Wakode - as we discussed offline - this was changed directly by the developer without consultation in the raised thread, and digressed from the initial reviews. It also lacks a screenshot or demo of the final design, not allowing reviewers a chance to see what changed. We should not expedite unreviewed merges like this since they create a lot of rework Moreover, this blocks it from UX signoff perspective, since it diverges from the design, and creates a risk for delivery Going forward, any changes to the provided design should be discussed with designers internally in publicly raised threads, and changes will be explicitly called out. |
|
@BenGSchulz - please note the design for HITL QuickForms where design team recommends the changes, and use those as review references going forward. |
Design time: a Text area starts one line tall, like a Text field. As the text wraps or gets new lines, it grows up to 8 lines and then scrolls.
Runtime: no change.