Repository navigation
docs: say Limit is not used in the remaining settings tables (2.1) - #297
Closed
cosmin-staicu wants to merge 2 commits into
Closed
cosmin-staicu wants to merge 2 commits into
cosmin-staicu wants to merge 2 commits into
Conversation
The broadcast guide's table, the settings reference and the sample's full settings file still described Limit as the number of entries one read returns. Nothing reads it. Signed-off-by: Cosmin Staicu <cosmin.staicu@uipath.com>
cosmin-staicu
requested review from
alinahornet,
cosminvlad,
florin-munteanu-uipath,
litheon,
lucianaparaschivei and
razvalex
as code owners
October 24, 2026 09:29
…list Signed-off-by: Cosmin Staicu <cosmin.staicu@uipath.com>
|
Member
Author
|
Folded into #293. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #296 to 2.1.x. Same three lines; #295 fixed the prose on 2.1.
The settings tables in the broadcast guide and the settings reference, and the sample's full settings file, still described
RedisStreamsTopicOptions.Limitas the number of entries one read returns. Nothing readsLimit: the reader asks forPollBatchSizeentries, and the publisher trims withMaxLengthonly. #294 (main) fixed the guide's prose. This fixes the three remaining places, so the docs no longer contradict each other.Docs only.