Wait for OAuth connect actionability instead of reading the first paint - #1828
Draft
RhysSullivan wants to merge 1 commit into
Draft
Wait for OAuth connect actionability instead of reading the first paint#1828RhysSullivan wants to merge 1 commit into
RhysSullivan wants to merge 1 commit into
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 98e2734 | Aug 28 2026, 01:20 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 98e2734 | Commit Preview URL Branch Preview URL |
Aug 28 2026, 01:20 PM |
Contributor
Cloudflare preview
Sign-in is Cloudflare Access (one-time PIN to an allowed email). The preview has its own database and encryption key; it is destroyed when this PR closes. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a new e2e flake:
connection-modal-oauth-abandonfailed twice within an hour on unrelated bases (runs 33153832122 on changeset-release, 33156980537) with the same assertion — "the auto-selected app makes Connect with OAuth actionable: expected true to be false".The test waited for the button to be visible, then read
isDisabled()once. The app picker's auto-selection resolves asynchronously after the modal opens, so the button legitimately renders disabled for a beat before enabling; the one-shot read raced that. It now waits for actionability (a trial click waits for enabled + stable) before the assertion. A genuine regression where the button never enables still fails, via the trial-click timeout.Checks: lint, typecheck, focused
cloud/connection-modal-oauth-abandon.test.tsrun.