Repository navigation
Support fading counters with correct upkeep sacrifice timing - #330
Open
valzargaming wants to merge 2 commits into
Open
valzargaming wants to merge 2 commits into
valzargaming wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Tests exercise the complete fading lifecycle, zero/last counters, indestructibility and sacrifice observers, counter payments/response additions and removals, original-controller restrictions, source removal/blink, multiple instances, save/resume, and a distinct Vanishing regression.
Recognition, not blanket gameplay support
Same hashed local MTGJSON
5.3.0+20261019corpus, after #329:New wholly recognized entries: Blastoderm, Cloudskate, Defender en-Vec, Jolting Merfolk, Phyrexian Prowler, Rejuvenation Chamber, Skyshroud Behemoth, Skyshroud Ridgeback, Woodripper. Their relevant counter effects/lifecycle are tested; this is not a certification of every possible interaction. Ancient Hydra, Tangle Wire and other complex cards still expose unsupported text. Coverage remains incomplete. See
docs/fading-coverage.md.