Skip to content

Fix TwitchPHP API contracts, auth lifecycle and EventSub recovery - #9

Merged
valzargaming merged 1 commit into
mainfrom
audit-runtime-and-api-correctness
Oct 12, 2026
Merged

valzargaming merged 1 commit into
mainfrom
audit-runtime-and-api-correctness

Conversation

@valzargaming

@valzargaming valzargaming commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Fix repository request methods, identifiers, context, pagination and response hydration; add current Hype Train models and public iCalendar downloads.
  • Correct token recovery/validation, close-during-bootstrap behavior, EventSub reconnect/handoff/replay, and React Promise 2.11 compatibility.
  • Add bounded IRC message throttling, webhook signature handling, conduit subscription helpers, documentation and synthetic regression coverage.
  • Preserve the legacy desiredSubscriptions() map; expose all channels/versions through desiredSubscriptionSpecs().
  • Retain contributor/dependency guidance and add Windows plus lowest-dependency CI coverage.

Verification

  • Focused offline API suite: 73 tests / 196 assertions passed before final review changes.
  • New lifecycle, string-cursor and compatibility regressions passed individually.
  • Composer dependency provenance and security audit passed using published packages.
  • phpDocumentor configured build passed; generated compilation report has no errors.
  • Fresh composer verify: 134 tests / 526 assertions passed on Windows PHP 8.5.9 with published current dependencies.
  • Fresh lowest-dependency suite: 134 tests / 524 assertions passed (39 upstream deprecations on PHP 8.5).
  • Exact-head CI passed all four jobs: Ubuntu PHP 8.4/8.5, Windows PHP 8.4 and lowest dependencies: https://github.com/Valgorithms/TwitchPHP/actions/runs/38279237023

Limits

  • No live Twitch calls, credentials, release, documentation publication or deployment.
  • Lowest supported vendor versions emit upstream deprecations under local PHP 8.5; remote CI also covers PHP 8.4.
  • This PR retains the published twitchphp/http dependency; transport-package work remains separate.

Final review

  • Resolved review findings: late bootstrap readiness after close, generic string pagination cursors and compatibility of the existing desiredSubscriptions() accessor.
  • No unresolved blocking finding from local source review. Copilot could not provide a review because its requesting user reached the quota limit.

@valzargaming
valzargaming marked this pull request as ready for review October 12, 2026 16:43
Copilot AI balanced review requested due to automatic review settings October 12, 2026 16:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@valzargaming
valzargaming merged commit 3b1af0d into main Oct 12, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants