Repository navigation
fix(ci): pin vcpkg on Windows so libjxl 0.12 is installed - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
v1.8.0release failed onBuild - x86_64-pc-windows-msvc, so the Release job was skipped and no binaries were published. This pins vcpkg on the Windows runner so the right libjxl is installed.Cause
jpegxl-rs0.15 (updated in chore(deps): update dependencies to latest #30) needslibjxl >= 0.12.0. On Linux and macOS it builds libjxl itself (vendored); on Windows it takes libjxl from vcpkg.windows-latestis older and only provides libjxl 0.11.2, so the build script ofjpegxl-sysfails withCannot find `libjxl` with version >= 0.12.0.v1.8.0was the first run to hit it.Changes (
.github/workflows/ci.yml, step "Install native dependencies (Windows)")VCPKG_COMMIT, then bootstrap it beforevcpkg install. The result no longer depends on the vcpkg that the runner image ships. When a-syscrate needs newer libraries, only that one line changes.$PSNativeCommandUseErrorActionPreference = $trueso the step stops at the first failinggit fetch,git checkoutor bootstrap. Without it the failure is ignored and the old libjxl gets installed, which gives the same confusing error as this one.Testing
Release
v1.8.0has its Docker image published but no GitHub Release. After this is merged, the plan is to releasev1.8.1.Generated by Claude Code