Skip to content

Complete and highlight animations for the current ConditionState model - #126

Open
ViTeXFTW wants to merge 1 commit into
devfrom
t3code/complete-model-animations
Open

ViTeXFTW wants to merge 1 commit into
devfrom
t3code/complete-model-animations

Conversation

@ViTeXFTW

@ViTeXFTW ViTeXFTW commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Summary

Animation and IdleAnimation previously offered no model-specific suggestions and highlighted animation names as plain strings. They now suggest qualified animation names compatible with the current ConditionState model's skeleton and highlight those names as references.

  • Index raw, compressed, and morph animation headers from loose W3D files and BIG archives, retaining model-to-skeleton associations and rebuilding older index caches.
  • Resolve explicit state models and models inherited from the preceding DefaultConditionState in the same draw module, including TransitionState. Respect model overrides and asset removal.
  • Replace the entire qualified name when accepting completion, preserve optional distance/repeat arguments, and highlight those arguments as numbers.
  • Add completion specs, parser/index regression tests, archive/cache coverage, and wire-level completion and semantic-token checks.

Tests

  • Passed cargo test --workspace --quiet (corpus and opt-in benchmark tests remain ignored).
  • Passed cargo clippy --locked --all-targets --all-features -- -D warnings.
  • Passed cargo fmt --all --check and git diff --check.
  • Built the server and passed all stdio end-to-end checks, including animation completion and full/range semantic highlighting.
  • No schema or opener-oracle changes; the real-game corpus gate was not required.

Checklist

  • I kept the change focused.
  • I ran the relevant checks or explained why they were skipped.
  • I did not commit generated artifacts, game source, corpus data, or secrets.

@greptile-apps

greptile-apps Bot commented Sep 8, 2026

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no concrete correctness, security, or repository-rule issue remains.

Summary

  • Extracts raw, compressed, and morph animation headers from loose W3D files and BIG archives.
  • Associates models and animations by skeleton while respecting indexed overrides and removals.
  • Resolves explicit and inherited ConditionState models for completion.
  • Replaces complete qualified animation names while preserving quotes and optional numeric arguments.
  • Adds unit, specification, cache, archive, and end-to-end regression coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant