Fix CI: /status probe over 127.0.0.1, slash-safe branch tags, tidy status nesting - #6
Merged
Merged
Conversation
BusyBox wget resolves localhost to ::1 first and nginx only listens on IPv4, so the /status probe was refused. Branch names containing a slash (feature/x) are not valid Docker tags; map the slash to a dash.
The embedded restore/backup objects had their opening brace indented
along with the body, so the key line read '"restore": {'. Indent
every line but the first. The CI probe now also asserts the restore
reached state done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BusyBox
wgetresolveslocalhostto::1first and nginx listens on IPv4 only, so the new/statusprobe in the startup test was refused; branch names containing a slash were producing an invalid Docker tag (pre-existing, only affectedfeature/*branches); and the embedded restore/backup objects in/statushad their opening brace indented along with the body ("restore": {).CI-only plus a one-line
sedchange inhealth-monitor.sh. No image behaviour change. The CI probe now also asserts the archive restore reached"state": "done".Note the
mainrun after #5 failed at this test step, so no:latestimage was published from that merge; the nextmainrun (or a release tag) will.