Skip to content

fix: hide the Splunk Cloud stack name at untrusted output boundaries - #83

Open
JacobPEvans-personal wants to merge 8 commits into
mainfrom
feat/cloud-target-redaction
Open

JacobPEvans-personal wants to merge 8 commits into
mainfrom
feat/cloud-target-redaction

Conversation

@JacobPEvans-personal

@JacobPEvans-personal JacobPEvans-personal commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

First of a 3-PR stack replacing #80. Redaction only, no write code.

  • With VCT_SPLUNK_REDACT_TARGET set to a truthy value, the output formatter hides Splunk Cloud stack names in everything it renders: JSON/table data and metadata, error-envelope messages and details, and write confirmation prompts. Commercial and FedRAMP ACS paths are covered. The audit log is unaffected and always records the real host.
  • splunk inspect reports stack_configured: bool instead of echoing the Cloud stack name.
  • Cloud integration test failure messages no longer include the target URL or captured command output.
  • The Splunk Cloud Read Canary workflow calls pytest directly and sets the redaction variable.
  • Adds utils.validation.env_flag, shared by every boolean environment variable that is not a write gate.

Test plan

  • ruff check ., ruff format --check ., pyright, pytest (1059 passed)
  • tests/unit/test_redact_public_text.py: opt-in, truthy values, ports, Enterprise targets untouched, credential stripping, ACS path variants, idempotency
  • auth status data and metadata, and the error envelope, covered in test_auth.py and test_output.py

🤖 Generated with Claude Code

https://claude.ai/code/session_01MkCDG3PVVwxfoLyGSpg9is

Opt-in via VCT_SPLUNK_REDACT_TARGET=1: hides the Cloud stack label in
prompts, JSON metadata, and transport error text, without touching the
audit log (which still records the real host). `splunk inspect` reports
`stack_configured: bool` instead of echoing the stack name. The Splunk
Cloud Read Canary workflow sets the variable and scans its own pytest
output for a leaked target or credential before publishing anything.
Copilot AI lite review requested due to automatic review settings August 18, 2026 11:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants