Fix: wrong ontology IRI due to OWL API bug #1080 - #220
Closed
Artemis-IA wants to merge 1 commit into
Closed
Conversation
Update Dockerfile to build OWL2VOWL from Artemis-IA/OWL2VOWL (branch fix-owlapi-1080) which uses a patched OWL API 5.1.1 that fixes owlcs/owlapi#1080. Bug #1080: when an ontology declares owl:imports and has a self-referencing annotation (e.g. rdfs:isDefinedBy → ontology IRI), OWL API incorrectly assigns an imported ontology's IRI as the main ontology IRI, causing WebVOWL to display the wrong ontology IRI. See: - owlcs/owlapi#1080 - VisualDataWeb/OWL2VOWL#75 - owlcs/owlapi#1178
Author
|
Closing this PR. We need to run more comprehensive tests across all OSO ontology versions before submitting. Will reopen once validation is complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
owl:imports+ self-referencing annotationsProblem
When WebVOWL loads an ontology that has both
owl:importsdeclarations and a self-referencing annotation (e.g.rdfs:isDefinedBy → <ontology-iri>), the ontology IRI shown in the WebVOWL UI is incorrect — it displays an imported ontology's IRI (e.g.http://www.w3.org/ns/prov-o) instead of the actual ontology IRI.This is caused by a bug in OWL API's RDF/XML parser (not in WebVOWL or OWL2VOWL). Self-referencing annotations are valid and standard semantic web practice.
Fix
This PR changes the Dockerfile to build OWL2VOWL from Artemis-IA/OWL2VOWL (branch
fix-owlapi-1080), which upgrades the OWL API dependency to a patched version of 5.1.1 built via JitPack.The OWL API fix was originally committed by @vChavezB (commit b1768cdf) on the
version5branch, but no Maven release has been published.Related PRs
Test plan
https://w3id.org/earthsemantics/OSOinstead ofhttp://www.w3.org/ns/prov-oOnce upstream is fixed
When both owlcs/owlapi publishes a release AND VisualDataWeb/OWL2VOWL merges the dependency upgrade, this Dockerfile should be reverted to use
VisualDataWeb/OWL2VOWL:master.