Repository navigation
Conversation
soreau
force-pushed
the
max-texture-size
branch
2 times, most recently
from
October 14, 2026 16:40
05549c1 to
ebd3e68
Compare
Contributor
|
applied - no issues so far, vulkan renderer |
soreau
force-pushed
the
max-texture-size
branch
from
October 18, 2026 16:47
ebd3e68 to
b345212
Compare
ammen99
reviewed
Oct 24, 2026
ammen99
reviewed
Oct 24, 2026
| /** | ||
| * Returns the maximum texture size for the gpu hardware. | ||
| */ | ||
| uint32_t get_hardware_maximum_texture_size(); |
Member
There was a problem hiding this comment.
I don't really think we need this in the public headers, but if you do want to have this here, it will need an api/abi version bump.
Otherwise should be moved to priv headers.
Member
Author
There was a problem hiding this comment.
Can you clarify to which priv header you are referring? I see opengl-priv.hpp but this is for vulkan and opengl.
Member
There was a problem hiding this comment.
opengl-priv would be fine. We don't yet have a vulkan-priv header but I suppose we could add it if more functions pop up.
soreau
force-pushed
the
max-texture-size
branch
from
October 25, 2026 02:30
b345212 to
3066c99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.