Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved critical nullability and moderate menu positioning and configuration issues remain.
4 open issues
What changed in this PR
Refactors Tollium menus to use native popovers, improve positioning and keyboard navigation, and update related tests.
Changes:
- Replaces
.openstate with:popover-open. - Updates menu lifecycle, positioning, and keyboard handling.
- Modernizes selectors, tests, and TypeScript usage.
| File | Review summary |
|---|---|
whtree/modules/webhare_testsuite/web/tests/pages/rte/menu.scss |
Updated menu selectors. |
whtree/modules/webhare_testsuite/tests/tollium/richdoc/teststructured-tables.ts |
Added menu visibility assertions. |
whtree/modules/webhare_testsuite/tests/tollium/components/testmenus.ts |
Critical nullable openSubmenu usage requires narrowing. |
whtree/modules/webhare_testsuite/tests/tollium/components/testiframe.ts |
Updated popover selectors. |
whtree/modules/webhare_testsuite/tests/system/setup/testsetup.ts |
Updated open-menu selector. |
whtree/modules/tollium/webdesigns/webinterface/components/menuitem/menuitem.ts |
Updated menu selection event handling. |
whtree/modules/tollium/web/ui/css/apps.scss |
Updated menubar styling selectors. |
whtree/modules/tollium/web/ui/components/basecontrols/menu.ts |
Coordinate-space inconsistencies, event/element misclassification, and a documentation typo require correction. |
whtree/modules/tollium/web/ui/components/basecontrols/menu.css |
Updated styles for popover-open menus. |
whtree/modules/tollium/js/testframework.ts |
Updated menu lookup helpers. |
whtree/modules/system/js/wh/testframework.ts |
Updated open-menu detection. |
whtree/modules/platform/data/siteprofiles/types.siteprl.yml |
Removing meo leaves existing consumers without a siteprofile definition. |
Review effort: Lite
Comment on lines
+123
to
+124
| const openSubmenu = test.getOpenMenu(); | ||
| X07 = test.qSA(openSubmenu, "li").filter(item => item.textContent.includes('X07'))[0]; |
| width: 0, | ||
| height: 0 | ||
| }; | ||
| const viewport: dompack.Rect = { left: 0, top: 0, right: viewsize.x, bottom: viewsize.y, width: viewsize.x, height: viewsize.y }; |
Comment on lines
+1142
to
+1143
| const x = (at.pageX || 0) - window.scrollX; | ||
| const y = (at.pageY || 0) - window.scrollY; |
| @param parentmenu | ||
| - @param preferredalign - left/right (only used when preferreddirection is 'up' or 'down') | ||
| @param exitdirection - '', 'top', 'left' - cursor direction in which the selection can be removed | ||
| @param exitdirection - '', 'top', 'left' - cursor directio in nwhich the selection can be removed |
![webharebot[bot]](https://avatars.githubusercontent.com/u/14281356?s=60&v=4){kind=small}
There was a problem hiding this comment.
🤖 Auto-Approved: PR author (@unilynx) is an internal organization/repository member.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor menu system to use less IE6-style positioning. Restore keyboard support
.openclass with the:popover-openstate for menu elementsMenuListclass to set thepopover="manual"attribute and manage the new popover state