Skip to content

fix(starter): Redis drop-in fatal when REDIS_PORT is unset #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
palicko merged 1 commit into from
Oct 22, 2026
Merged

fix(starter): Redis drop-in fatal when REDIS_PORT is unset #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/webentor-starter/config/application.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,16 @@
/**
* REDIS CLIENT
*/
Config::define('WP_REDIS_HOST', env('REDIS_HOST') ?? '');
Config::define('WP_REDIS_PORT', env('REDIS_PORT') ?? '');
// Only override when set: empty strings beat the drop-in's 127.0.0.1:6379 defaults, and phpredis needs an int port
if (env('REDIS_HOST')) {
Config::define('WP_REDIS_HOST', env('REDIS_HOST'));
}
if (env('REDIS_PORT')) {
Config::define('WP_REDIS_PORT', (int) env('REDIS_PORT'));
}
Config::define('WP_REDIS_DISABLED', env('WP_REDIS_DISABLED'));
// Default on: sites often share one Redis db, where a full flush would wipe every site's cache
Config::define('WP_REDIS_SELECTIVE_FLUSH', env('WP_REDIS_SELECTIVE_FLUSH') ?? true);

/**
* Define SENTRY vars.
Expand Down
11 changes: 9 additions & 2 deletions test-site/config/application.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,16 @@
/**
* REDIS CLIENT
*/
Config::define('WP_REDIS_HOST', env('REDIS_HOST') ?? '');
Config::define('WP_REDIS_PORT', env('REDIS_PORT') ?? '');
// Only override when set: empty strings beat the drop-in's 127.0.0.1:6379 defaults, and phpredis needs an int port
if (env('REDIS_HOST')) {
Config::define('WP_REDIS_HOST', env('REDIS_HOST'));
}
if (env('REDIS_PORT')) {
Config::define('WP_REDIS_PORT', (int) env('REDIS_PORT'));
}
Config::define('WP_REDIS_DISABLED', env('WP_REDIS_DISABLED'));
// Default on: sites often share one Redis db, where a full flush would wipe every site's cache
Config::define('WP_REDIS_SELECTIVE_FLUSH', env('WP_REDIS_SELECTIVE_FLUSH') ?? true);

/**
* Define SENTRY vars.
Expand Down
Loading