Repository navigation
Fix/integration findings - #8
Merged
Merged
Conversation
Input and Textarea emit string | undefined (defineModel); bindInput declared string only, which vue-tsc reported for <Input v-bind="bindInput(field)" />. A type test in packages/vue/typecheck checks the bind helpers against the components. Signed-off-by: Florian Laabs <florian.laabs@wirecore.net>
Variant, size, status and data types that appear in public props came only from @wirecore/wirelayer-recipes, a transitive dependency of apps. Signed-off-by: Florian Laabs <florian.laabs@wirecore.net>
Without data-mode the dark colors, the dark variant and the dark overrides of the themes apply when the system is dark; data-mode=light|dark forces a mode. Charts recolor when the system setting changes. Signed-off-by: Florian Laabs <florian.laabs@wirecore.net>
German moves to locales/de like the other languages; only English is built in. The DataTable gets csvSeparator, by default from the locale. The docs no longer claim German as the default. Signed-off-by: Florian Laabs <florian.laabs@wirecore.net>
Parts of the DataTable that bring a lot of code along are imported on their own and passed in `features`: virtualRows (from /virtual, the only import of TanStack Virtual), dateInput and numberInput. Without them date and number filters and editors use the browser's inputs and `virtual` renders all rows with a hint in development. A minimal table is about a fifth smaller (gzip). Signed-off-by: Florian Laabs <florian.laabs@wirecore.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Findings from integrating WireLayer into an app, plus smaller bundles.
features– a minimal table is about a fifth smaller (gzip)Breaking (0.x minor): German must be registered (registerLocale('de', de)); DataTable
virtualneeds virtualRows, date/number inputs need dateInput/numberInput; localeEmojis(texts) no longer takes a locale. See the changesets.