65766 - Added aria-describedby for search engine visibility setting by sawfly · Pull Request #12794 · WordPress/wordpress-develop

sawfly · 2026-07-31T15:29:47Z

Added attribute aria-describedby

Trac ticket: https://core.trac.wordpress.org/ticket/65766

github-actions · 2026-07-31T15:29:56Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sawf1y, afercia, abcd95.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2026-07-31T15:33:13Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

himanshupathak95 · 2026-08-03T10:30:01Z

 <td><fieldset>
 	<legend class="screen-reader-text"><span><?php echo $blog_privacy_selector_title; ?></span></legend>
 <?php if ( has_action( 'blog_privacy_selector' ) ) : ?>
 	<input id="blog-public" type="radio" name="blog_public" value="1" <?php checked( '1', get_option( 'blog_public' ) ); ?> />


Could we also add aria-describedby="public-desc" to the radio buttons here and id="public-desc" to the <p class="description"> here as well? This will ensure the setting is fully accessible even when blog_privacy_selector is active, matching wp-admin/install.php

File wp-admin/install.php contains aria-describedby attribute within input id="blog-norobots". Should I add aria-describedby to input.blog-public, input.blog-norobots or probably both?

Should I add aria-describedby to input.blog-public, input.blog-norobots or probably both?

Sorry, I missed this reply.

himanshupathak95 · 2026-08-03T10:34:05Z

 	?>
 <?php else : ?>
-	<label for="blog_public"><input name="blog_public" type="checkbox" id="blog_public" value="0" <?php checked( '0', get_option( 'blog_public' ) ); ?> />
+	<label for="blog_public"><input name="blog_public" type="checkbox" id="blog_public" value="0" aria-describedby="privacy-desc" <?php checked( '0', get_option( 'blog_public' ) ); ?> />


For attribute consistency with wp-admin/install.php#L201, let's move aria-describedby="privacy-desc" to right after id="blog_public

himanshupathak95 · 2026-08-04T05:50:49Z

Thanks for updating the attribute ordering, @sawfly! That looks much cleaner now.

Just a reminder regarding the remaining part of the review: the radio button section inside if ( has_action( 'blog_privacy_selector' ) ) (lines 215–219) is still missing aria-describedby and an id on its description paragraph.

To make the accessibility fix complete across all view states, could you also update that branch? In wp-admin/install.php, core handles this exact radio button setup similarly, you can refer from there for consistency check.

sawfly · 2026-08-04T08:22:53Z

Thanks for updating the attribute ordering, @sawfly! That looks much cleaner now.

Just a reminder regarding the remaining part of the review: the radio button section inside if ( has_action( 'blog_privacy_selector' ) ) (lines 215–219) is still missing aria-describedby and an id on its description paragraph.

To make the accessibility fix complete across all view states, could you also update that branch? In wp-admin/install.php, core handles this exact radio button setup similarly, you can refer from there for consistency check.

Dear @himanshupathak95 . Thanks for your involving in this PR. I've done as you asked to match install.php. In this comment you had asked to add aria-describedby to both radio buttons? In wp-admin/install.php the first radio button does not have attribute aria-describedby. I asked you in reply. So, if the goal was to match public visibiliti option exactly with wp-admin/install.php, that it have done now

himanshupathak95

To clarify my earlier comment: yes, only #blog-norobots needs aria-describedby, not #blog-public. The description text is a caveat specifically about how the discouraging option works, so linking it only to that input is semantically accurate.

Both branches now look correct. I think the fix is now complete and consistent across both view states.

afercia · 2026-09-19T11:31:25Z

I rebased the PR and updated it to conditionally set aria-describedby in the fieldset.
Plus, other a11y improvements to use explicit labeling etc.
Also updated the install.php page.

…ovements.

afercia · 2026-09-20T09:42:16Z

 			<td><input name="weblog_title" type="text" id="weblog_title" size="25" value="<?php echo esc_attr( $weblog_title ); ?>" /></td>
 		</tr>
 		<tr>
-			<th scope="row"><label for="user_login"><?php _e( 'Username' ); ?></label></th>


This label was not associated with any input when $user_table is truthy, as the input is rendered conditionally.

…ility. Conditionally associates the description of the Search engine visibility setting on the Reading Settings and Install pages: - When the setting shows two radio buttons, the description is associated to the wrapping fieldset element. - Otherwise, it is associated to the checkbox. Additionally: - Fixes an orphaned label element in the Install page. - Replaces implicit labeling (label elements that wrap inputs) with explicit labeling. Developed in #12794 Props sawf1y, abcd95, afercia, joedolson. Fixes #65766. git-svn-id: https://develop.svn.wordpress.org/trunk@63762 602fd350-edb4-49c9-b593-d223f7449a82

…ility. Conditionally associates the description of the Search engine visibility setting on the Reading Settings and Install pages: - When the setting shows two radio buttons, the description is associated to the wrapping fieldset element. - Otherwise, it is associated to the checkbox. Additionally: - Fixes an orphaned label element in the Install page. - Replaces implicit labeling (label elements that wrap inputs) with explicit labeling. Developed in WordPress/wordpress-develop#12794 Props sawf1y, abcd95, afercia, joedolson. Fixes #65766. Built from https://develop.svn.wordpress.org/trunk@63762 git-svn-id: http://core.svn.wordpress.org/trunk@62934 1a063a9b-81f0-0310-95a4-ce76da25c4cd

afercia · 2026-09-20T10:47:09Z

Committed in https://core.trac.wordpress.org/changeset/63762

himanshupathak95 reviewed Aug 3, 2026

View reviewed changes

sawfly requested a review from himanshupathak95 August 3, 2026 13:45

himanshupathak95 approved these changes Aug 5, 2026

View reviewed changes

afercia force-pushed the 65766-Add-aria-described-for-search-engine-setting branch from b177029 to a25196c Compare September 19, 2026 11:29

sawfly and others added 4 commits September 19, 2026 13:31

Added aria-describedby for search engine visibility setting

931dbee

changed attribute order

17aac28

Added attribute aria-describedby to match install.php

aa97cb3

Conditionally set aria-describedby on the fieldset and more a11y impr…

a0113ff

…ovements.

afercia force-pushed the 65766-Add-aria-described-for-search-engine-setting branch from a25196c to a0113ff Compare September 19, 2026 11:32

Remove unnecessary new empty line.

0871e45

afercia reviewed Sep 20, 2026

View reviewed changes

afercia added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Sep 20, 2026

github-actions Bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Sep 20, 2026

afercia closed this Sep 20, 2026

Navigation Menu

65766 - Added aria-describedby for search engine visibility setting - #12794

65766 - Added aria-describedby for search engine visibility setting#12794
sawfly wants to merge 5 commits into
WordPress:trunkfrom
sawfly:65766-Add-aria-described-for-search-engine-setting

sawfly commented Jul 31, 2026 •

edited by afercia

Loading

Uh oh!

github-actions Bot commented Jul 31, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

himanshupathak95 Aug 3, 2026 •

edited

Loading

Uh oh!

sawfly Aug 3, 2026

Uh oh!

himanshupathak95 Aug 5, 2026

Uh oh!

himanshupathak95 Aug 3, 2026

Uh oh!

himanshupathak95 commented Aug 4, 2026

Uh oh!

sawfly commented Aug 4, 2026

Uh oh!

himanshupathak95 left a comment

Uh oh!

afercia commented Sep 19, 2026

Uh oh!

afercia Sep 20, 2026

Uh oh!

afercia commented Sep 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

sawfly commented Jul 31, 2026 • edited by afercia Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 31, 2026

Test using WordPress Playground

Some things to be aware of

Uh oh!

himanshupathak95 Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sawfly Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

himanshupathak95 Aug 5, 2026

Choose a reason for hiding this comment

Uh oh!

himanshupathak95 Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

himanshupathak95 commented Aug 4, 2026

Uh oh!

sawfly commented Aug 4, 2026

Uh oh!

himanshupathak95 left a comment

Choose a reason for hiding this comment

Uh oh!

afercia commented Sep 19, 2026

Uh oh!

afercia Sep 20, 2026

Choose a reason for hiding this comment

Uh oh!

afercia commented Sep 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sawfly commented Jul 31, 2026 •

edited by afercia

Loading

github-actions Bot commented Jul 31, 2026 •

edited

Loading

himanshupathak95 Aug 3, 2026 •

edited

Loading