Login and Registration: Ensure language switcher button remains readable - #13611
Draft
ArkaPrabhaChowdhury wants to merge 1 commit into
Draft
ArkaPrabhaChowdhury wants to merge 1 commit into
ArkaPrabhaChowdhury wants to merge 1 commit into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
ArkaPrabhaChowdhury
force-pushed
the
trac-66130-login-language-button-background
branch
from
September 18, 2026 18:03
dfd528c to
7a2e345
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The login language switcher uses the default secondary button style, which now has a transparent background. On customized login screens with dark backgrounds, this can leave the button text and border without sufficient visual separation.
This adds the standard light admin background color specifically to the language switcher button so it remains readable independently of the login page background.
Trac ticket: https://core.trac.wordpress.org/ticket/66130
Testing
wp-login.php.#3c3c3c.#f6f7f7background and remains readable.Browser verification confirmed the button background changes from transparent before the patch to
rgb(246, 247, 247)after the patch, while retaining the existing text and border colors.Checks run:
grunt precommit:cssphp vendor/bin/phpcbf src/wp-login.phpphp vendor/bin/phpcs src/wp-login.phpgit diff --checkUse of AI Tools
AI assistance: Yes
Tool(s): Codex
Model(s): GPT-5
Used for: Ticket analysis, implementation, browser verification, test execution, and drafting this pull request description.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.