Skip to content

Login and Registration: Ensure language switcher button remains readable - #13611

Draft
ArkaPrabhaChowdhury wants to merge 1 commit into
WordPress:trunkfrom
ArkaPrabhaChowdhury:trac-66130-login-language-button-background
Draft

ArkaPrabhaChowdhury wants to merge 1 commit into
WordPress:trunkfrom
ArkaPrabhaChowdhury:trac-66130-login-language-button-background

Conversation

@ArkaPrabhaChowdhury

Copy link
Copy Markdown

The login language switcher uses the default secondary button style, which now has a transparent background. On customized login screens with dark backgrounds, this can leave the button text and border without sufficient visual separation.

This adds the standard light admin background color specifically to the language switcher button so it remains readable independently of the login page background.

Trac ticket: https://core.trac.wordpress.org/ticket/66130

Testing

  1. Install an additional language so the language switcher appears on wp-login.php.
  2. Set the login page background to #3c3c3c.
  3. Confirm that the language switcher button has a #f6f7f7 background and remains readable.

Browser verification confirmed the button background changes from transparent before the patch to rgb(246, 247, 247) after the patch, while retaining the existing text and border colors.

Checks run:

  • grunt precommit:css
  • php vendor/bin/phpcbf src/wp-login.php
  • php vendor/bin/phpcs src/wp-login.php
  • git diff --check

Use of AI Tools

AI assistance: Yes
Tool(s): Codex
Model(s): GPT-5
Used for: Ticket analysis, implementation, browser verification, test execution, and drafting this pull request description.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@ArkaPrabhaChowdhury
ArkaPrabhaChowdhury force-pushed the trac-66130-login-language-button-background branch from dfd528c to 7a2e345 Compare September 18, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant