Conversation
…b is missing during PclZip extraction
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
What this fixes
When a PHP installation is missing both the
ZipArchiveclass and the zlib extension (gzopen()),unzip_file()falls through to the bundled PclZip library, whose constructor callsdie('Abort class-pclzip.php : Missing zlib extensions'). This is an untranslated, unstyled fatal error rather than the usualWP_Errorthat callers (like the plugin/theme upload screens) expect and render nicely.The fix
_unzip_file_pclzip()insrc/wp-admin/includes/file.phpthat detects the missing zlib extension before ever instantiatingPclZip, and returns a translatableWP_Error(unzip_file_missing_zlib) instead.unzip_file_pclzip_zlib_availablefilter (mirroring the existingunzip_file_use_ziparchivefilter in the same file), which also makes the new behavior directly unit-testable without needing an actual zlib-less PHP build.class-pclzip.phpuntouched, since it's third-party library code.Testing
test_should_return_wp_error_when_zlib_extension_is_unavailable()intests/phpunit/tests/filesystem/unzipFilePclzip.php, which forces the new filter tofalseand asserts aWP_Errorwith the new error code is returned.filetest group, PHPCS, and PHPStan — all green.Trac ticket: https://core.trac.wordpress.org/ticket/30963
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5
Used for: Implementation, tests, and PR description. Reviewed by Igor Rozum.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
🤖 Generated with Claude Code