Skip to content

Upload: Return a translatable error instead of a fatal error when zlib is missing during PclZip extraction - #13613

Open
irozum wants to merge 2 commits into
WordPress:trunkfrom
irozum:fix/30963-pclzip-missing-zlib-error-message
Open

irozum wants to merge 2 commits into
WordPress:trunkfrom
irozum:fix/30963-pclzip-missing-zlib-error-message

Conversation

@irozum

@irozum irozum commented Sep 18, 2026

Copy link
Copy Markdown

What this fixes

When a PHP installation is missing both the ZipArchive class and the zlib extension (gzopen()), unzip_file() falls through to the bundled PclZip library, whose constructor calls die('Abort class-pclzip.php : Missing zlib extensions'). This is an untranslated, unstyled fatal error rather than the usual WP_Error that callers (like the plugin/theme upload screens) expect and render nicely.

The fix

  • Added a check at the top of _unzip_file_pclzip() in src/wp-admin/includes/file.php that detects the missing zlib extension before ever instantiating PclZip, and returns a translatable WP_Error (unzip_file_missing_zlib) instead.
  • The check is exposed via a new unzip_file_pclzip_zlib_available filter (mirroring the existing unzip_file_use_ziparchive filter in the same file), which also makes the new behavior directly unit-testable without needing an actual zlib-less PHP build.
  • Left the vendored class-pclzip.php untouched, since it's third-party library code.

Testing

  • Added test_should_return_wp_error_when_zlib_extension_is_unavailable() in tests/phpunit/tests/filesystem/unzipFilePclzip.php, which forces the new filter to false and asserts a WP_Error with the new error code is returned.
  • Ran the full file test group, PHPCS, and PHPStan — all green.
  • This bug only reproduces on PHP builds lacking zlib, which practically all modern installs have, so it isn't reproducible via manual UI steps in this repo's local dev environment; the added/passing test is the verification path.

Trac ticket: https://core.trac.wordpress.org/ticket/30963

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5
Used for: Implementation, tests, and PR description. Reviewed by Igor Rozum.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

🤖 Generated with Claude Code

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props irozum.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant