Skip to content

Fix translation lookups inside the loop - #13616

Draft
mukeshpanchal27 wants to merge 1 commit into
WordPress:trunkfrom
mukeshpanchal27:perf/fix-translation-lookups
Draft

mukeshpanchal27 wants to merge 1 commit into
WordPress:trunkfrom
mukeshpanchal27:perf/fix-translation-lookups

Conversation

@mukeshpanchal27

@mukeshpanchal27 mukeshpanchal27 commented Sep 19, 2026

Copy link
Copy Markdown
Member

Trac ticket:

While working on PR 13615 found this one.

Two translation lookups inside the loop. _x( 'F j, Y', 'daily archives date format' ) and __( 'Posts published on %s' ) were re-translated once per day that has posts, firing gettext_with_context / gettext up to 31 times each. Both are hoisted above the loop.

Use of AI Tools

N/A


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@mukeshpanchal27 mukeshpanchal27 self-assigned this Sep 19, 2026
@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@mukeshpanchal27

Copy link
Copy Markdown
Member Author

@swissspidy Does this change make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant