FED-5022 Drop Dart 2 support - #1013
Merged
Merged
Conversation
…iles - Raise environment.sdk to '>=3.9.0 <4.0.0' - Delete Dart-2-only test files (non_null_safe_builder_integration_tests, unsound_flux_component_test.dart, over_react_component_declaration_non_null_safe_test.dart) and analyzer plugin non_null_safe test directories - Remove dart_test.yaml no-dart-2 preset and dart-2-only tag - Update CI test_and_check_generated_files matrix from [2.19.6, stable] to [3.9.0, stable]; remove Delete-Dart-2-only-files step and --preset=no-dart-2 branching - Update CI validate_analyzer: move ^5.13.0 row into the main matrix (no longer needs the 2.19.6 include); remove Delete-Dart-2-only-files step and --preset=no-dart-2 branching - Update CI analyzer_plugin: remove the travis_link_plugin_deps.dart link step (plugin now resolves published over_react 5.7.0 rather than the local checkout); remove Delete-Dart-2-only-files step Note: lib/ has analysis errors from classes used as mixins (class_used_as_mixin) that require `mixin class` or `mixin` declarations — these need follow-up fixes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
greglittlefield-wf
marked this pull request as ready for review
September 21, 2026 18:05
| fail-fast: false | ||
| matrix: | ||
| sdk: [ 2.19.6, stable ] | ||
| sdk: [ 3.9.0, stable ] |
Contributor
Author
There was a problem hiding this comment.
This is kind of arbitrary; I just picked an older-but-not-too-old version of Dart 3
greglittlefield-wf
force-pushed
the
drop-dart-2-support
branch
from
September 21, 2026 18:45
1de0bf2 to
a0e488f
Compare
danaoredson-wf
approved these changes
Sep 21, 2026
Member
|
QA +1 CI passes. Builds and runs in our internal app. |
Contributor
Author
|
@Workiva/release-management-p |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Maintaining a large range of analyzer versions comes with a bit of overhead, and getting to the latest analyzer versions (#1012) while also supporting Dart 2 just isn't feasible.
We've supported Dart 2 + 3 in the same version of over_react for a while, and now it's time to drop Dart 2 support.
Changes
>=2.19to>=3.0.0class-used-as-mixin errors. From CHANGELOG.md:
Remove unreachable switch statement
defaultcasesUse modern equivalent to implicit-casts flag in analysis_options.yaml
have ever been exported
QA steps