[hpetriffer]

Problem

Member completion on the loop variable of FOREACH VAR showed nothing when the collection is a generic local or parameter:

LOCAL aList := System.Collections.Generic.List<Customer>{} AS System.Collections.Generic.List<Customer>
FOREACH VAR oItem IN aList
    ? oItem:     // no members
NEXT

Same for a Customer[] array (it offered the members of System.Array) and for Dictionary<STRING, Customer> (pair:Value: showed nothing).

Causes

1. FindIdentifier replaced the TypeName of a local/parameter with the resolved type's full name. For a .NET generic that is List<T>, so GenericArgs became ["T"] and the element type T could not be found.
2. ResolveImpliedCollection returned the array type for X[] instead of the element type.
3. The element type was taken from the indexer. Dictionary<TKey,TValue>[TKey] returns TValue, but the loop enumerates KeyValuePair<TKey,TValue>.
4. AdjustGenericMember only fixed the TypeName of the cloned member (QuickInfo was right). Completion reads ResolvedType, which was still resolved from TValue.

Changes (XSharpLookup.cs only)

• Keep the declared type arguments when a local or parameter is resolved (WithTypeArguments, GetTypeArguments; type arguments are split at the top level and trimmed).
• Arrays: the loop variable gets the element type.
• Generic .NET collections: the element type comes from the IEnumerable<T> implementation in the metadata, with the collection's type arguments filled in. The indexer stays as the fallback.
• After AdjustGenericMember, resolve the ResolvedType of the adjusted member.

Known limitation: the generic member adjustment still runs only at the end of a chain, so a deeper chain such as pair:Value:Name: is not covered yet.

Test

Checked manually in VS 2022 (experimental instance) with the old parser. Completion now lists the members of Customer for a local List<Customer>, a local Customer[], a parameter List<Customer> and pair:Value: over a Dictionary<STRING, Customer>. VAR x := Customer{} and FOR VAR n := 1 TO 3 work as before.

🤖 Generated with Claude Code