Skip to content

[Vsintegration] XDatabase: register the collation before the VACUUM #2132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobertvanderHulst merged 1 commit into from
Oct 28, 2026
Merged

[Vsintegration] XDatabase: register the collation before the VACUUM #2132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/VisualStudio/XSharpCodeModelXs/Database/XDatabase.prg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,12 @@ STATIC METHOD SetPragmas(oConn AS DbConnection) AS VOID
Log("Set the pragmas for the database")
USING VAR oCmd := CreateCommand("PRAGMA foreign_keys = ON", oConn)
oCmd:ExecuteNonQuery()
// Register the collation before the VACUUM: the VACUUM rebuilds the NOCASE indexes with the collation
// that is registered at that moment. With the built-in NOCASE the indexes no longer match the custom
// NOCASE of Microsoft.Data.Sqlite, lookups miss rows and SQLite reports "database disk image is malformed".
oConn:SetCollation()
oCmd:CommandText := "VACUUM"
oCmd:ExecuteNonQuery()
oConn:SetCollation()
CATCH e AS Exception
Log("Error setting pragmas")
XSettings.Exception(e)
Expand Down