Conversation
Record completed installations in the installed Xcode cache before updating the row, and discard directory scans started before the cache changed. This prevents list recomposition from reverting a newly installed Xcode to not installed. Extend the existing Apple and Xcode Releases installation tests to verify that installed state survives available-list and selection updates.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a successful installation, Xcode can appear as not installed until a manual refresh. The row is updated, but the installed Xcode cache is not, so rebuilding the list can overwrite the installed state.
Update the cache when installation completes and ignore stale directory scan results.
Extend the existing Apple and Xcode Releases installation tests to verify that the installed state survives list and selection updates. Both tests fail without the cache update and pass with it.