Repository navigation
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## pynq-next #1669 +/- ##
==========================================
Coverage 34.04% 34.04%
==========================================
Files 42 42
Lines 4814 4814
Branches 837 837
==========================================
Hits 1639 1639
Misses 3110 3110
Partials 65 65 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a comprehensive update to the RFSoC
xrfdcdriver moving to the latest PYNQ-supported version of the tools (2025.2) and exposing much more of the embeddedSW C driver functionality than before (including MTS). This should be almost entirely backwards compatible with code targeting the old driver (except the RFSoC-MTS repo, and a few non-critical functions described at the bottom here), so no changes to your codebase should be necessary.Classic driver (
sdbuild/packages/xrfdc)libxrfdc.sofrom embeddedswxilinx_v2025.2(wasxilinx-v2020.2), with the updated stubs andxparameters.hxrfdc_functions.cstructs and prototypes with the 2025.2xrfdc.h, including the reworked clock distribution and signal detector structsMultiConverter_Init,MultiConverter_Sync,MTS_Sysref_Config,MTSEnableCustomStartUp,WaitForState,MultiBandSignalDetector,Coupling/LinkCoupling,DACDataScaler,ConnectedIQData,SetClkDistributionMax/MinSampleRate,GetFabClkFreq,GetDriverVersion,GetTileLayout, block/tile enable and data-type gettersRDReg,ClrSetReg,ClrRegGetConnectedIData/GetConnectedQDatanot returning a value;GetCalCoefficientsandGetFIFOStatusObsnow return values andSetCalCoefficientstakes a dictNCOFreqand DACLinkCouplingHWH parameters, with defaults so older HWH files still loadShutDowntoShutdownto match C (ShutDownkept as an alias); bump the package to 2.0Remote driver (
pynq-cppgRPC server andpynq.remote.xrfdc)xrfdc.protowith RPCs for every newly wrapped function and reshape clock distribution to the 2025.2 struct (old field numbers reserved)xrfdc.cc/xrfdc.hxrfdc_pb2*.pyBreaking changes
ClkDistributionis now read-only and returns the 2025.2 system struct (Distributions[8]); write throughSetClkDistribution(dict)GetCalCoefficients(block)returns a dict,SetCalCoefficients(block, dict)takes one, andGetFIFOStatusObs()returns the value directly