Repository navigation
feat: resilient desktop login and MCP service guidance - #224
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and behavior
Change walkthrough
desktop/src-tauri/src/bootstrap.rsusesnet.rsfor connection budgets;session.rs,auth.rs, anddevice_login.rshandle startup, saved-session verdicts, and login retries. Backend MCP discovery retains service metadata incore/llm/mcp/session.pyandlifetime.py;server_guidance.pyrenders it andcore/llm/factory/assembly.pyappends it to the runtime prompt.features/desktop/bridge/gateway.pycarries gateway service labels/descriptions.CatalogPanel.tsxcloses details outside the selected category.ed9253e1is merged; the documentation conflict retains the implemented 10-second connection timeout fromnet.rs. Main's review workflow and shared rules are preserved. With feat: persistent sandbox snapshots and design workflow skills #222 and feat: slim desktop updates, cached capabilities, and current CE features #223 merged, the current diff is 21 files, 515 insertions, and 124 deletions.Risk and compatibility
Verification
a5e018a4, all 19 PR-context unit tests, all 79 desktop-script tests, andgit diff --cached --checkpassed before the commit. The merge leaves no unresolved paths. Prior validation of parent64835085passed CE publication gates, isolated import/OpenAPI/ORM checks, CE release regressions, and the CE frontend build. The corresponding product changes passed 32 backend tests, 117 UOS tests, and three native macOS retry tests.Recovery
Review follow-up
desktop/UPDATE_SIZE_DESIGN.mdis resolved against the actual timeout constant. feat: persistent sandbox snapshots and design workflow skills #222 and feat: slim desktop updates, cached capabilities, and current CE features #223 are already on main. Runtime code remains unchanged from the prior PR head; review and CI of the updated merge head are pending.Community checklist