Repository navigation
perf(solar): persistent Vision engine and direct LSML scene admission - #78
Conversation
Agent-Role: eleven Agent-Thread: 01a116c8-c342-7e62-b783-59953e085982 Work-Unit: local-20261007-vision-integration Issue: none Evidence: qualified source-delivery candidate; local validation renewed 2026-10-07
Agent-Role: eleven Agent-Thread: 01a116c8-c342-7e62-b783-59953e085982 Work-Unit: local-20261007-vision-integration Issue: none
Agent-Role: Eleven Agent-Thread: 01a116c8-c342-7e62-b783-59953e085982 Work-Unit: local-20261007-vision-integration Issue: user-request Evidence: evidence/local-20261007-vision-integration/eleven/20261007T201000Z-authoring-report.json
Agent-Role: Eleven Agent-Thread: 01a116c8-c342-7e62-b783-59953e085982 Work-Unit: local-20261007-vision-integration Issue: user-request
Agent-Role: Eleven Agent-Thread: 01a116c8-c342-7e62-b783-59953e085982 Work-Unit: local-20261007-vision-integration Issue: user-request
Agent-Role: Eleven Agent-Thread: 01a116c8-c342-7e62-b783-59953e085982 Work-Unit: local-20261007-vision-integration Issue: user-request Evidence: Solar typecheck lint build layout and 197 tests passed
Apply LSDP mutations independently of Orion, preload installation fonts, and transfer canonical LSML with addressed assets to one persistent engine. Agent-Role: eleven Agent-Thread: 01a11a8b-8f4f-7fc2-abc4-7983042e4f63 Work-Unit: local-20261008-solar-merge Issue: #78 Evidence: evidence/local-20261008-solar-merge/eleven/20261008T123900Z-candidate.md
ClodoCapeo
changed the title
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
AGENT_REPORT / MERGE_ATTESTATION Eleven, thread01a11a8b-8f4f-7fc2-abc4-7983042e4f63, unitlocal-20261008-solar-merge. Final head421495ae759e7f69728507d557030eef640b66a3, signed commit verified by GitHub. User explicitly authorized Solar push and merge. 225unit tests, TypeScript, product ESLint, source/map/docs/size checks,5tooling tests and pinned bundle/native client PASS locally. Required GitHub file-sizes workflow SUCCESS on this exact head (run37778433679). Candidate report: evidence/local-20261008-solar-merge/eleven/20261008T123900Z-candidate.md. Local measured switch/mutation/HTTP image evidence summarized in evidence/local-20261008-render-preparation/eleven/20261008T122600Z-results.json. Decision: integrate by repository-supported squash merge, matching this exact head. No release tag or deployment. Rollback by reverting merge. Separate Vision source remains local/unmerged although vendored artifacts are pinned; remaining internal JSON/worker clone/Rust-GPU costs are recorded. Global workspace guard remains blocked solely by foreign active Pulsar evidence names; preserve those files and do not claim global closure. Large private proofs/font installation caches are excluded from this public PR. |
|
CLOSURE_REPORT — Solar integration completed PR78 merged2026-10-08T12:40:31Z; main9dc261e8747ad07a294815b58adb442d546941fb. GitHub merge signature Verified (reasonvalid). Merge tree exactly equals tested head421495ae759e7f69728507d557030eef640b66a3. CI SUCCESS both before merge (run37778433679) and on main after merge (run37778570590). No release tag, deployment or Prism-launcher change. Existing active worktree, private proofs and caches preserved for session continuation. Separate Vision source branch remains unmerged; vendored artifact provenance is explicit. Global workspace closure remains BLOCK from foreign active Pulsar evidence paths; this report closes only the authorized Solar GitHub integration. Next scope discussed with user: account-scoped accessible ZabCanvas sources downloaded and synchronized by Prism-launcher, consumed locally by Solar; no inactive render-scene retention. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 421495ae75
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const layer = existing?.layer ?? document.createElement("div"); | ||
| layer.dataset.solarVisionScene = delivery.sceneVersion; | ||
| Object.assign(layer.style, { | ||
| position: "absolute", | ||
| inset: "0", | ||
| opacity: "0", | ||
| pointerEvents: "none", |
There was a problem hiding this comment.
When a solar/program or solar/preview transition enters prepare with an existing persistent session, layer is the currently visible shared layer, so setting its opacity to zero immediately blanks the accepted scene. The prepare path only calls pending.scene.activate() later during commit, leaving Program/Preview blank for the entire prepare-to-commit interval and also preventing the advertised compensation frame from remaining visible. Staging must not hide or overwrite the active presentation before commit.
Useful? React with 👍 / 👎.
| if ( | ||
| !assets || | ||
| assets.origin.sceneId !== document.scene_id || | ||
| assets.origin.sceneVersion !== document.scene_version | ||
| ) { |
There was a problem hiding this comment.
When an LSDP update adds or replaces x-solar-authoring while retaining the same scene_id and scene_version, this identity-only check reuses the previous published NativeSceneAssets and never calls readNativeAuthoringSource(document). The new authoring envelope is therefore neither validated nor used, and any newly embedded image/font assets are absent when Vision loads the edited document. Reuse must also account for authoring-envelope provenance/content, or reacquire assets whenever that extension changes.
Useful? React with 👍 / 👎.
| schema_version: "solar.host.contract.v1", | ||
| protocol_version: "solar.host.v2", |
There was a problem hiding this comment.
The generated archive now declares solar.host.v2 here, while scripts/create-runtime-manifest.mjs still publishes the same release as protocol_version: "solar.host.v1". Installers consuming the outer runtime manifest can consequently reject or classify the v2 native-LSDP host as the legacy v1 contract even though the extracted host advertises v2. Emit one consistent protocol version in both manifests.
Useful? React with 👍 / 👎.
* feat(solar): render direct LSML with Vision and native LSDP Agent-Role: eleven Agent-Thread: 01a116c8-c342-7e62-b783-59953e085982 Work-Unit: local-20261007-vision-integration Issue: none Evidence: qualified source-delivery candidate; local validation renewed 2026-10-07 * fix(host): publish Vision contract and linked qualification records Agent-Role: eleven Agent-Thread: 01a116c8-c342-7e62-b783-59953e085982 Work-Unit: local-20261007-vision-integration Issue: none * feat(vision): render addressed editable drafts with native bindings Agent-Role: Eleven Agent-Thread: 01a116c8-c342-7e62-b783-59953e085982 Work-Unit: local-20261007-vision-integration Issue: user-request Evidence: evidence/local-20261007-vision-integration/eleven/20261007T201000Z-authoring-report.json * fix(authoring): admit standard system font envelopes Agent-Role: Eleven Agent-Thread: 01a116c8-c342-7e62-b783-59953e085982 Work-Unit: local-20261007-vision-integration Issue: user-request * feat(vision): integrate native authoring and capture composition Agent-Role: Eleven Agent-Thread: 01a116c8-c342-7e62-b783-59953e085982 Work-Unit: local-20261007-vision-integration Issue: user-request * perf(vision): omit empty trailing capture surfaces Agent-Role: Eleven Agent-Thread: 01a116c8-c342-7e62-b783-59953e085982 Work-Unit: local-20261007-vision-integration Issue: user-request Evidence: Solar typecheck lint build layout and 197 tests passed * perf(solar): preserve Vision engine and streamline scene admission Apply LSDP mutations independently of Orion, preload installation fonts, and transfer canonical LSML with addressed assets to one persistent engine. Agent-Role: eleven Agent-Thread: 01a11a8b-8f4f-7fc2-abc4-7983042e4f63 Work-Unit: local-20261008-solar-merge Issue: #78 Evidence: evidence/local-20261008-solar-merge/eleven/20261008T123900Z-candidate.md * feat(solar): demonstrate retained LSML sponsor transitions Adopt the current isolated dev baseline and play sponsor image transitions through native LSDP, Solar and Vision. Bind translation to active scene coordinates instead of reloading for each sample. Agent-Role: Eleven Agent-Thread: 01a124c8-8595-7f01-92fd-bf0d24ba8bd1 Work-Unit: local-20261010-sponsor-motion Evidence: evidence/local-20261010-sponsor-motion/eleven/20261010T080849Z-capture.json * feat(solar): demonstrate LSML traveling wave motion Reuse retained image translations and source crops for a sampled wave fixture, with native playback and actual-canvas endpoint/replay evidence. Agent-Role: Eleven Agent-Thread: 01a124c8-8595-7f01-92fd-bf0d24ba8bd1 Work-Unit: local-20261010-sponsor-motion Evidence: evidence/local-20261010-sponsor-motion/eleven/20261010T091139Z-wave-checkpoint.md * fix(solar): render sponsor waves continuously at measured cadence Replace cropped image rows with two whole textures and retained Vision wave bindings. Pin the local continuous-mesh engine, validate animation ranges and shared start time, and retain actual-canvas quality and cadence evidence. Agent-Role: Eleven Agent-Thread: 01a124c8-8595-7f01-92fd-bf0d24ba8bd1 Work-Unit: local-20261010-sponsor-motion Evidence: evidence/local-20261010-sponsor-motion/eleven/20261010T093026Z-continuous-wave-checkpoint.md * feat(solar): compose retained motion timelines and native controls Compile nested sequential and parallel tracks, property curves, cubic paths and bounded springs. Drive retained Vision transforms and effects without geometry reloads. Add native playback controls and primitive LSML keyframe replay, with compatibility documentation and actual-canvas proof. Agent-Role: Eleven Agent-Thread: 01a124c8-8595-7f01-92fd-bf0d24ba8bd1 Work-Unit: local-20261010-sponsor-motion Evidence: evidence/local-20261010-sponsor-motion/eleven/20261010T101407Z-composed-motion-checkpoint.md * feat: reconstruct reference motion with retained vector tracks Add validated SVG path morphing and retained stroke reveal channels. Reconstruct an OpenAI reference sequence from generated vector contours and LSML tracks, with native Solar/Vision playback, controls, pixel replay and cadence evidence. Agent-Role: Eleven Agent-Thread: 01a124c8-8595-7f01-92fd-bf0d24ba8bd1 Work-Unit: local-20261010-sponsor-motion Evidence: evidence/local-20261010-sponsor-motion/eleven/20261010T110229Z-vector-motion-checkpoint.md * fix: reconstruct reference bounces and preserve topology changes Replace the rejected visual interpretation with measured vector contour motion. Keep recorded poses at topology changes and qualify aligned native timestamps and half-frame positions, separate from actual real-time canvas capture. Reuse accepted catalogue compilation for native clones and fix hold boundaries. Agent-Role: Eleven Agent-Thread: 01a124c8-8595-7f01-92fd-bf0d24ba8bd1 Work-Unit: local-20261010-sponsor-motion Evidence: evidence/local-20261010-sponsor-motion/eleven/20261010T114348Z-reference-motion-checkpoint.md * fix: preserve exact native client bytes across checkout Pinned upstream Git blobs use CRLF. Protect only those four immutable files from text normalization and verify their provenance in PR CI. Record acceptance of the final vector reference fixture. Agent-Role: Eleven Agent-Thread: 01a124c8-8595-7f01-92fd-bf0d24ba8bd1 Work-Unit: local-20261010-sponsor-motion Evidence: evidence/local-20261010-sponsor-motion/eleven/20261010T125000Z-publication-manifest.json * fix: declare upstream carriage returns in pinned files Keep whitespace diagnostics while recognizing the exact upstream CRLF endings for four vendored blobs. Agent-Role: Eleven Agent-Thread: 01a124c8-8595-7f01-92fd-bf0d24ba8bd1 Work-Unit: local-20261010-sponsor-motion * docs: persist motion publication and native runtime checks Agent-Role: Eleven Agent-Thread: 01a124c8-8595-7f01-92fd-bf0d24ba8bd1 Work-Unit: local-20261010-sponsor-motion Evidence: evidence/local-20261010-sponsor-motion/eleven/20261010T130100Z-publication-checkpoint.md
Solar now keeps one Vision engine across scene switches, preloads installation fonts once per engine, and admits fresh canonical LSML with addressed assets directly into Rust/WASM. Received LSDP mutations apply and render without an Orion query or producer feedback. Editable content remains a continuous LSDP mutation stream. Each scene selection reacquires its source and replaces the active scene; no inactive rendered scene is retained.
The source/asset/font changes preserve LSMLZ import/export, integrity checks, Blue revision metadata, and HTTP image binding mutations. The standalone host performs no catalogue synchronization. Existing immutable source-store adapters remain available for the upcoming Prism-launcher integration.
Validation on final candidate: 225 unit tests in31files, TypeScript, product ESLint, architecture/documentation/map/size checks,5tooling tests, runtime layout, native portable client and four Vision artifact pins pass. Full build passed on the same product source; only documentation changed afterward. Local lint excluded untracked ad hoc .cache scripts; they are not published.
Isolated local proof:40switches on one engine; warm standard mean187.01ms and editable61.77ms; firststandard422.3ms reported separately.390scalar mutations produced390distinctframes at130.18frames/s with mean send-to-submission3.07ms. A real Rust LSDP HTTP image mutation changed4095pixels with oneGET, no scene reload and the same engine. These measure submission/front-canvas behavior, not physical scan-out, Internet performance, actual Blue execution or Prism/Pulsar qualification.
Evidence: evidence/local-20261008-solar-merge/eleven/20261008T123900Z-candidate.md and evidence/local-20261008-render-preparation/eleven/20261008T122600Z-results.{md,json}. Large raw traces, videos, installation fonts and private screenshots remain local.
Limits: internal Vision patch/metadata JSON, worker whole-state clone and deeper Rust/images/GPU costs remain open. Vendored Vision artifacts are byte-pinned and honestly identify local uncommitted upstream font/direct-parts source on merged base031788f; this PR does not merge that separate Vision source branch. Native Rust receiver revision remains e695e14f. The rejected GPU pixel-changing shortcut is absent. Global workspace closure remains blocked by foreign active Pulsar evidence names; those files are preserved.
User explicitly authorized Solar push and merge. No ADR, release tag or deployment. Rollback by reverting this PR merge.