Repository navigation
feat(solar): pin retained Vision material fixes - #80
Conversation
Pin the signed Vision build and hash manifest, and preserve mixed native-composition behavior with regression coverage and validation evidence. Agent-Role: Eleven Work-Unit: local-20261011-vision-merge Issue: none Evidence: evidence/local-20261011-vision-merge/eleven/
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 584447c2ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| kind: "image", | ||
| id: "image", | ||
| blendMode: "difference", |
There was a problem hiding this comment.
When a mixed scene has an image above a capture with an absent or normal blendMode—the default state before an inspector blend mutation—prepareNativeComposition skips its isolation branch and groups the image with adjacent Solar objects. This test always initializes the image as difference, so it passes while the newly documented stable normal-mode band contract remains unimplemented; changing such an image's blend later leaves Pulsar without an image-only source and causes the whole band to be composited as the blend contribution. Isolate image nodes regardless of their current blend mode and add a default/normal case here.
Useful? React with 👍 / 👎.
Record the verified Vision merge revision in the pinned asset manifest and validation report. Agent-Role: Eleven Work-Unit: local-20261011-vision-merge Issue: none Evidence: evidence/local-20261011-vision-merge/eleven/
|
MERGE_ATTESTATION — Solar PR #80 merged as f627cf6. GitHub verifies the merge signature as valid. Signed source commits: 584447c and f47202d. Solar manifest pins verified Vision merge e5b2720589e30820bd6b70b89cc78fec0ab6153a and its generated JS/WASM hashes. CI file-size passed; local lint, typecheck, 261 tests, build, bundle and architecture checks passed. Evidence: https://github.com/ZabLaboratory/Solar/tree/main/evidence/local-20261011-vision-merge/eleven/. Roll back with git revert f627cf6. Recorded after the verified merge. |
|
CLOSURE_REPORT — mandate to push and merge all remaining Solar and Vision work: complete. Vision #7 merged as e5b2720589e30820bd6b70b89cc78fec0ab6153a with all nine checks passing; Solar #80 merged as f627cf6 with its file-size workflow passing. Signed commits: Vision 64d0cfc7d7a539d1e4c7fcfcddafbf771bacd49e; Solar 584447c and f47202d. Local proofs: Solar lint, typecheck, 261 Vitest cases, build, artifact bundle and architecture checks; Vision fmt, all-feature workspace tests, Clippy, docs, 20 browser tests and WebAssembly build. Evidence: https://github.com/Lumencast/lumencast-vision/tree/main/evidence/local-20261011-vision-merge/eleven/ and https://github.com/ZabLaboratory/Solar/tree/main/evidence/local-20261011-vision-merge/eleven/. Limitation: npm ci reported 6 audit findings (5 moderate, 1 high); no dependencies changed. No deployment or Prism restart was included. Rollback: revert e5b2720589e30820bd6b70b89cc78fec0ab6153a in Vision and f627cf6 in Solar. No force push. No remaining work for this mandate. |
Pins the signed Vision renderer build and its SHA-256 manifest, and records the remaining mixed native composition contract with regression coverage. Scene library/startup synchronization from earlier Solar work is already present on main and is not duplicated here. Validation: lint, typecheck, 261 tests, build, bundle checks and architecture checks pass locally. This pull request depends on Vision PR #7; merged revision provenance will be updated after that PR lands.