Repository navigation
fix: Only read the cached token of the SSO profile used - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes SSO bearer token selection and validation on the credential path; behavior differs when multiple SSO sessions are cached.
Overview
Fixes SSO login so the CLI uses the same cached token as AWS CLI for the profile’s
sso_session, instead of scanning the cache directory and picking the first JSON file with anaccessToken.SsoConfignow carries profile and sso_session_name.get_bearer_tokenopens~/.aws/sso/cache/{sha1(session)}.json(via new sha1 dependency), deserializesaccessToken/ expiresAt, rejects expired tokens, and surfacesaws sso login --profile …hints on failure.Unit tests cover the SHA-1 cache filename and expiration handling.
Reviewed by Cursor Bugbot for commit 1a57cec. Bugbot is set up for automated code reviews on this repo. Configure here.