Skip to content

fix(styles): move the last raw colour literals into tokens.css (§4.1.1) - #58

Closed
buddywhitman wants to merge 1 commit into
ZeroPointRepo:mainfrom
Guaq-AI:fix-raw-colour-literals
Closed

buddywhitman wants to merge 1 commit into
ZeroPointRepo:mainfrom
Guaq-AI:fix-raw-colour-literals

Conversation

@buddywhitman

Copy link
Copy Markdown
Contributor

The "no raw colour literals outside tokens.css (§4.1.1)" step in ci.yml has failed every run on main since at least 1 October, on two lines:

  • src/components/ConnectCallout.astro:74: the dark surface hex appeared in a comment. The comment now says "near-black".
  • src/components/SiteHeader.astro:435: the More menu's float shadow was an inline rgb(). It is now --shadow-float in src/styles/tokens.css, and the header uses var(--shadow-float). The value is unchanged.

No visual change. The gate's grep now returns nothing, and check-contrast.mjs and check-hub-intros.mjs pass.

Follow-up to #57 (Employed), which surfaced the red ci run.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DCSn5sr8sYzppbRPy4wR9X

The "no raw colour literals outside tokens.css" step has failed every CI run on main:
- ConnectCallout.astro:74 named the dark surface hex in a comment; it now says "near-black".
- SiteHeader.astro:435 had the More menu's float shadow inline; it is now --shadow-float in
  tokens.css, the only file allowed to carry colour values.

No visual change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DCSn5sr8sYzppbRPy4wR9X
scheemunai pushed a commit that referenced this pull request Oct 13, 2026
Merged from PR #58. ConnectCallout's comment hex is reworded to prose and the
SiteHeader More-menu shadow now uses a new --shadow-float token (value
unchanged — no visual change). Clears the §4.1.1 grep so main's ci runs green
again.

Co-Authored-By: buddywhitman <buddywhitman@users.noreply.github.com>
Co-Authored-By: CRHQ <noreply@crhq.ai>
@scheemunai

Copy link
Copy Markdown
Contributor

Applied to main (718e78b) and live on https://grokbot.dev — and main's ci is green again for the first time since the regression landed. Thank you, this was exactly the right fix: the comment reword costs nothing and --shadow-float is a genuinely better home for that shadow than an inline literal.

One process note rather than a criticism: the merge gate is content-only by design (community PRs may only ADD files under content/ — code changes come in through a maintainer, per the gate's own message), so I applied your branch to main directly instead of merging the PR. Credit is in the commit's Co-Authored-By trailers.

Maintainer edits: none — your diff went in exactly as submitted. I ran the local gate before pushing (npm run build + contrast + hub-intro checks, all green), and the deployed CSS now carries --shadow-float with the value unchanged.

Thanks again — clean diagnosis, minimal diff, and it un-blocks every future autopublish run from landing red.

@scheemunai scheemunai closed this Oct 13, 2026
@buddywhitman
buddywhitman deleted the fix-raw-colour-literals branch October 13, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants