Repository navigation
Leave punctuation in annotations uncolored - #6
Merged
Merged
Conversation
Brackets, commas and colons in annotations and def/class headers were linked to Delimiter/Operator, so in colorschemes with a bright Delimiter (retrobox, gruvbox) they stood out more than the types, and looked different from the same punctuation in ordinary code. The groups still exist for users who want to link them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NHGQAYx5m3Fs5HUYPdtUWt
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Only a minor README clarification remains, with no approval-blocking issues.
Review effort: Lite
Findings: None
What changed in this PR
Updates Python syntax highlighting so annotation and definition-header punctuation remains unlinked by default while preserving customization groups.
Changes:
- Removes five default punctuation highlight links.
- Adds loading assertions.
- Updates README and help documentation.
| File | Reviewed change |
|---|---|
tests/test_loading.vim |
Verifies punctuation groups remain unlinked. |
syntax/python.vim |
Removes default punctuation links. |
README.md |
Documents customization; clarify that guidance includes def/class headers. |
doc/python-syntax-enhanced.txt |
Updates highlight-group documentation and changelog. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brackets, commas and colons in annotations and def/class headers (
pythonTypeBracket,pythonTypeComma,pythonTypeColon,pythonParams,pythonDefColon) were linked toDelimiter/Operator. In colorschemes with a brightDelimiter(e.g.retrobox, where it's#fe8019orange), they drew more attention than the types themselves. They also looked different from the same punctuation in ordinary code (list(read(path))stays plain). They're now unlinked, like the rest of Python's punctuation; the groups still exist for anyone who wants to link them.Checklist
tests/test_syntax.vimortests/test_loading.vimthat fail without the change (5 new link checks fail onmain)sh tests/run.shpasses (68 + 12 assertions, Vim 9.1 and Neovim 0.12.5)doc/python-syntax-enhanced.txtand its changelog