Repository navigation
test: cover match/case and forward references; correct CI versions in README - #8
Merged
Merged
Conversation
Both were listed as features without assertions. The README said CI runs Vim 9.2 on Linux; ubuntu-latest installs Ubuntu's Vim 9.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NHGQAYx5m3Fs5HUYPdtUWt
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Adds syntax coverage for match/case and quoted forward references, and corrects CI version details.
Changes:
- Adds six syntax assertions.
- Updates README compatibility versions by platform.
| File | Summary |
|---|---|
tests/test_syntax.vim |
Adds coverage for soft keywords and forward references. |
README.md |
Corrects CI version documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Updated the image in the README to show the new before and after comparison.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NHGQAYx5m3Fs5HUYPdtUWt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A pre-announcement check of the README and post claims found two gaps:
match/caseand quoted forward references ("User") are listed as features but had no assertions. This adds 6: both keywords as statements, both as ordinary variables (match = re.match(...),case = 1, which must not highlight), and forward references in a parameter and a return type. They pass onmaintoo; this is coverage for existing behavior, not a fix.ubuntu-latestinstalls Ubuntu's Vim 9.1 (patch 16); macOS and Windows run 9.2, and Neovim is 0.12.5.Checklist
sh tests/run.shpasses (74 + 12 = 86 assertions, Vim 9.1 and Neovim 0.12.5)