Repository navigation
fix: retain end-of-generation token logprobs - #2383
Open
Kumar-Abhimanyu wants to merge 2 commits into
Open
Kumar-Abhimanyu wants to merge 2 commits into
Kumar-Abhimanyu wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the sampler immediately produces an end-of-generation token, completions currently return empty probability arrays even with logprobs enabled. The generation loop exits before retaining that token's probability.
This change preserves the sampled end-of-generation token in probability metadata. Regular completions append its special-token spelling and probability; streamed completions carry it in the final chunk. Completion text, token usage, and cache keys retain their existing behavior. Requests without logprobs remain unchanged.
Fixes #1528.
Validation:
Full model-download/inference tests and GPU backends were not run. The proposed behavior includes special tokens only in probability metadata; maintainer feedback on the EOS probability contract is welcome.