Update repository references for rename to ably-pubsub-php - #222
Merged
Conversation
Repoint the two references tied to this repository's identity ahead of the rename ably-php -> ably-pubsub-php: the features workflow repository-name (which selects the ably-sdk-builds-ably-pubsub-php IAM role) and the README licence link. The Packagist package name ably/ably-php and the ably-php/<version> agent identifier are intentionally unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge until the repository is renamed
ably-php→ably-pubsub-php, in the programme's rename freeze window. Merging early pointsfeatures.ymlat theably-sdk-builds-ably-pubsub-phpIAM role, whose OIDC trust is bound to the new repository name, so the credential step would fail. Conversely, once the rename happens the old role name stops matching, so this is a same-window change in both directions.Sibling of ably-pubsub-ruby#457, ably-js#2298, ably-java#1237, ably-dotnet#1332 and ably-python#682. Prepared ahead of the PHP split work; it only updates strings inside the repo and does not rename anything.
What changed
.github/workflows/features.yml—repository-name: ably-pubsub-php. This input selects the per-repo sdk-builds IAM role, provisioned by infrastructure#13005 with the ID-qualified OIDC subject added by infrastructure#13054 (both merged).README.md— the licence badge's link target.That is the whole repo-identity surface: there is no docs-upload workflow, and
composer.jsoncarries no repository URL.Deliberately left as-is
ably/ably-php—composer.jsonname, thecomposer requireline and the poser.pugx.org badges. This is the package identity on Packagist, not the repository, and the legacy package keeps its name.ably-php/<version>agent identifier (src/AblyRest.php) and the tests asserting on it — a registered identifier; the family rename toably-pubsub-phpbelongs to the split, gated on ably-common#361.CHANGELOG.md— history; GitHub's redirect covers the links.Packagist tracks the package by its GitHub URL and updates via the GitHub webhook/app. After the rename, check the
ably/ably-phppackage page on packagist.org: if it still shows the old repository URL, use Edit on the package to update it tohttps://github.com/ably/ably-pubsub-phpand confirm auto-update still triggers on the next push. Packagist follows the redirect for fetches, but stale URLs are a known source of "not auto-updated" warnings.Post-rename verification
git ls-remotefrom an existing checkout and web redirects for repo / a PR / a file permalink.check.ymlmatrix green.features.ymlrun: AWS credential step succeeds and the upload lands atsdk.ably.com/builds/ably/ably-pubsub-php/main/…(the upload failure mode is silent).main.🤖 Generated with Claude Code