Skip to content

Update repository references for rename to ably-pubsub-php - #222

Merged
umair-ably merged 1 commit into
mainfrom
pubsub-split/rename-references
Sep 9, 2026
Merged

Update repository references for rename to ably-pubsub-php#222
umair-ably merged 1 commit into
mainfrom
pubsub-split/rename-references

Conversation

@umair-ably

Copy link
Copy Markdown
Contributor

Do not merge until the repository is renamed ably-phpably-pubsub-php, in the programme's rename freeze window. Merging early points features.yml at the ably-sdk-builds-ably-pubsub-php IAM role, whose OIDC trust is bound to the new repository name, so the credential step would fail. Conversely, once the rename happens the old role name stops matching, so this is a same-window change in both directions.

Sibling of ably-pubsub-ruby#457, ably-js#2298, ably-java#1237, ably-dotnet#1332 and ably-python#682. Prepared ahead of the PHP split work; it only updates strings inside the repo and does not rename anything.

What changed

  • .github/workflows/features.ymlrepository-name: ably-pubsub-php. This input selects the per-repo sdk-builds IAM role, provisioned by infrastructure#13005 with the ID-qualified OIDC subject added by infrastructure#13054 (both merged).
  • README.md — the licence badge's link target.

That is the whole repo-identity surface: there is no docs-upload workflow, and composer.json carries no repository URL.

Deliberately left as-is

  • Packagist package name ably/ably-phpcomposer.json name, the composer require line and the poser.pugx.org badges. This is the package identity on Packagist, not the repository, and the legacy package keeps its name.
  • ably-php/<version> agent identifier (src/AblyRest.php) and the tests asserting on it — a registered identifier; the family rename to ably-pubsub-php belongs to the split, gated on ably-common#361.
  • CHANGELOG.md — history; GitHub's redirect covers the links.

⚠️ Packagist

Packagist tracks the package by its GitHub URL and updates via the GitHub webhook/app. After the rename, check the ably/ably-php package page on packagist.org: if it still shows the old repository URL, use Edit on the package to update it to https://github.com/ably/ably-pubsub-php and confirm auto-update still triggers on the next push. Packagist follows the redirect for fetches, but stale URLs are a known source of "not auto-updated" warnings.

Post-rename verification

  • git ls-remote from an existing checkout and web redirects for repo / a PR / a file permalink.
  • check.yml matrix green.
  • features.yml run: AWS credential step succeeds and the upload lands at sdk.ably.com/builds/ably/ably-pubsub-php/main/… (the upload failure mode is silent).
  • Packagist package page shows the new repository URL and auto-updates on the next push to main.

🤖 Generated with Claude Code

Repoint the two references tied to this repository's identity ahead of
the rename ably-php -> ably-pubsub-php: the features workflow
repository-name (which selects the ably-sdk-builds-ably-pubsub-php IAM
role) and the README licence link.

The Packagist package name ably/ably-php and the ably-php/<version>
agent identifier are intentionally unchanged.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ttypic ttypic left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umair-ably
umair-ably marked this pull request as ready for review September 9, 2026 14:52
@umair-ably
umair-ably merged commit 49235cc into main Sep 9, 2026
18 of 20 checks passed
@umair-ably
umair-ably deleted the pubsub-split/rename-references branch September 9, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants