Skip to content

Add buy and sell confirmation modal with slippage settings #1112

Closed

Description

@Chucks1093

Summary

Build a trade confirmation modal that shows the user a price breakdown before submitting a swap, including estimated output, price impact, and an adjustable slippage tolerance input.

Scope

  • Modal triggered from KeyDetail buy/sell panel
  • Displays: input amount, estimated output, price impact bps, fee, and net received
  • Slippage tolerance input with presets: 0.5%, 1%, 2%, custom
  • High price impact warning banner when impact > 5%
  • Confirm and Cancel buttons; loading spinner on submission

Acceptance Criteria

  • All price breakdown fields display accurate values
  • Slippage preset buttons update tolerance correctly
  • Custom slippage input validates numeric range 0.1–50%
  • High impact warning appears when impact exceeds 5%
  • Modal closes and triggers transaction on Confirm

ETA

12 hours

Activity

  1. shobhamerabacha-star commented on Oct 17, 2026

    @shobhamerabacha-star

    Greetings,

    I looked into the details for "Add buy and sell confirmation modal with slippage settings" and would like to contribute the fix.

    I have reviewed the problem description and acceptance criteria for this issue. I have a clear, tested implementation ready with defensive error handling and 100% green CI proof.

    I will deliver a clean, well-tested, and production-ready PR promptly upon assignment. Kindly assign this issue to me.

    Thank you!

  2. Malcolm-Wander commented on Oct 17, 2026

    @Malcolm-Wander

    @Malcolm-Wander has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello maintainer,I’d love to work on this issue please,I promise to do a good and swift job..thank you.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Malcolm-Wander to this issue.

  3. pasedaadeolu commented on Oct 17, 2026

    @pasedaadeolu

    @pasedaadeolu has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello maintainer, please i will like to work on this issue

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @pasedaadeolu to this issue.

  4. cryptojayfx commented on Oct 17, 2026

    @cryptojayfx

    @cryptojayfx has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi maintainer I would like to work this issue

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @cryptojayfx to this issue.

  5. gominadaniel79-coder commented on Oct 17, 2026

    @gominadaniel79-coder

    @gominadaniel79-coder has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi Maintainer I will like to work on this issue I am capable of solving this issue

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @gominadaniel79-coder to this issue.

  6. DevScoopee commented on Oct 17, 2026

    @DevScoopee
    Contributor

    @DevScoopee has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    i can fix this kindly assign

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @DevScoopee to this issue.

  7. Alhaandr commented on Oct 18, 2026

    @Alhaandr

    @Alhaandr has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I would like to work on this issue, please.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Alhaandr to this issue.

  8. raskenite commented on Oct 18, 2026

    @raskenite

    @raskenite has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi maintainer. I would love to work on this issue.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @raskenite to this issue.

  9. Charlesmoses6260-hub commented on Oct 18, 2026

    @Charlesmoses6260-hub

    @Charlesmoses6260-hub has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi team,

    I would like to apply to work on this issue.

    I have reviewed the issue description and the repository structure, and I understand the requirements. I have relevant experience in the tech stack used for this project and I am confident I can deliver a clean, well-tested solution.

    My relevant experience:
    • Strong experience with the project's core language and framework
    • Familiar with open-source contribution workflow (forks, PRs, code reviews)
    • Experience writing clean, maintainable code with tests and documentation
    • I have completed similar issues in previous Waves / bounties

    I can start right away and will keep communication active with updates and a draft PR early. I will also ensure my solution follows the repo's contribution guidelines and includes tests where needed.

    I would love the opportunity to work on this and contribute to the project.

    Thank you for considering my application!

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Charlesmoses6260-hub to this issue.

  10. Remmi12 commented on Oct 18, 2026

    @Remmi12

    @Remmi12 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi team,

    I would like to apply to work on this issue.

    I have reviewed the issue description and the repository structure, and I understand the requirements. I have relevant experience in the tech stack used for this project and I am confident I can deliver a clean, well-tested solution.

    My relevant experience:
    • Strong experience with the project's core language and framework
    • Familiar with open-source contribution workflow (forks, PRs, code reviews)
    • Experience writing clean, maintainable code with tests and documentation
    • I have completed similar issues in previous Waves / bounties

    I can start right away and will keep communication active with updates and a draft PR early. I will also ensure my solution follows the repo's contribution guidelines and includes tests where needed.

    I would love the opportunity to work on this and contribute to the project.

    Thank you for considering my application!

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Remmi12 to this issue.

  11. Yerimahjr commented on Oct 18, 2026

    @Yerimahjr

    @Yerimahjr has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi maintainer I would like to work on this issue please assign

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Yerimahjr to this issue.

  12. Beneaththesky001 commented on Oct 18, 2026

    @Beneaththesky001

    @Beneaththesky001 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I’ve thoroughly reviewed the issue and have a clear understanding of the intended outcome. I’d like to take this on and deliver a well-integrated solution that meets the acceptance criteria while maintaining the quality and consistency of the existing project.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Beneaththesky001 to this issue.

  13. official-rex commented on Oct 18, 2026

    @official-rex

    @official-rex has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Allow me to fix this

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @official-rex to this issue.

  14. DammyAji commented on Oct 18, 2026

    @DammyAji
    Contributor

    @DammyAji has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Please kindly assign me

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @DammyAji to this issue.

  15. deborahogunjinmi592-byte commented on Oct 18, 2026

    @deborahogunjinmi592-byte

    @deborahogunjinmi592-byte has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi maintainer
    I'm interested in working on the issue
    Could you please assign it to me?

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @deborahogunjinmi592-byte to this issue.

  16. teethaking commented on Oct 18, 2026

    @teethaking

    @teethaking has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    'ive gone through the issue requirements and can implement a solution that meets the expected design and acceptance criteria

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @teethaking to this issue.

  17. Fabluchy commented on Oct 18, 2026

    @Fabluchy

    @Fabluchy has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I'll like to work on this issue please

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Fabluchy to this issue.

  18. therealjhay commented on Oct 18, 2026

    @therealjhay
    Contributor

    @therealjhay has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello maintainer, i would love to work on this issue

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @therealjhay to this issue.

  19. somotochukwu-dev commented on Oct 18, 2026

    @somotochukwu-dev

    @somotochukwu-dev has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi
    Please assign this issue to me
    Thanks

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @somotochukwu-dev to this issue.

  20. drips-wave commented on Oct 18, 2026

    @drips-wave

    Congratulations, @therealjhay! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @therealjhay: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  21. grantfox-oss commented on Oct 20, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @therealjhay's PR #1210 was approved and merged by @Chucks1093.

    🏆 @therealjhay: You earned 40 FoxPoints for this contribution! Your current tier: Builder (1,068 total points). Track your full progress on GrantFox.

    👏 Great work, @therealjhay! Keep contributing to accesslayerorg.

  22. drips-wave commented on Oct 20, 2026

    @drips-wave

    This issue has been completed by @therealjhay as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @therealjhay: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave program

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions