Repository navigation
feat: add trade history CSV export button on portfolio page (#857) - #1266
Open
whitezaddy wants to merge 1 commit into
Open
whitezaddy wants to merge 1 commit into
whitezaddy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #857
/profile?tab=trade-history).ExportTradeHistoryCsvButtoncomponent with authenticated access check, loading spinner (Loader2), and accessibility attributes (aria-busy).GET /users/:wallet/tradeswithout pagination limits via cursor-traversal infetchAllTrades.Date,Key Name,Type,Quantity,Price per Key,Total,Fee.trades-[wallet-truncated]-[date].csvviabuildTradeHistoryCsvFilename.Testing
pnpm lint— passed with 0 errors, 0 warningspnpm build— production TypeScript and Vite bundle build passedpnpm test— all 33 related unit and integration tests passed:src/utils/__tests__/tradeExport.utils.test.ts(CSV headers, rows, calculations, escaping, and filename)src/components/common/__tests__/ExportTradeHistoryCsvButton.test.tsx(auth visibility, loading spinner, complete trade fetch, and download trigger)src/pages/__tests__/ProfilePage.integration.test.tsx(tab header button presence and unauthenticated hiding)src/components/common/__tests__/TradeHistoryLedger.test.tsx(pre-existing table tests preserved)Checklist