Skip to content

Feat/1151 key split notification balance display - #1267

Merged
Chucks1093 merged 2 commits into
accesslayerorg:devfrom
whitezaddy:feat/1151-key-split-notification-balance-display
Oct 22, 2026
Merged

Chucks1093 merged 2 commits into
accesslayerorg:devfrom
whitezaddy:feat/1151-key-split-notification-balance-display

Conversation

@whitezaddy

Copy link
Copy Markdown
Contributor

Summary

Closes #1151

  • Implemented split event notification banner (KeySplitBanner) on key detail and portfolio pages, displaying the split ratio, pre-split balance, and post-split balance for 48 hours after execution (Add key split event notification and updated balance display #1151).
  • Added a "Split Applied" badge (SplitAppliedBadge) to highlight split keys in the portfolio positions table and profile holdings grid for 48 hours after a split event.
  • Built keySplitEvents.service.ts and useKeySplit.ts to manage realtime SplitExecuted socket events, calculate balances accurately, auto-expire banners/badges after 48 hours, and immediately invalidate/refetch wallet holdings upon split execution.
  • Added session dismissal support for the banner using sessionStorage so closing the banner clears it for the remainder of the session.
  • Added unit and integration tests across utilities, components, hooks, and pages.

Testing

  • pnpm lint (0 errors, 0 warnings)
  • pnpm build (tsc -b && vite build succeeded)
  • pnpm vitest run src/utils/__tests__/keySplit.utils.test.ts (22 passing tests)
  • pnpm vitest run src/components/common/__tests__/SplitAppliedBadge.test.tsx (2 passing tests)
  • pnpm vitest run src/components/common/__tests__/KeySplitBanner.test.tsx (4 passing tests)
  • pnpm vitest run src/hooks/__tests__/useKeySplit.test.tsx (5 passing tests)
  • pnpm vitest run src/pages/__tests__/CreatorDetailPage.keySplit.integration.test.tsx (4 passing tests)
  • pnpm vitest run src/pages/__tests__/WalletPortfolioPage.keySplit.integration.test.tsx (3 passing tests)
  • pnpm vitest run src/pages/__tests__/WalletPortfolioPage.test.tsx (6 passing tests)

Checklist

@Chucks1093
Chucks1093 merged commit d6968d9 into accesslayerorg:dev Oct 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add key split event notification and updated balance display

2 participants