Repository navigation
Feat/1151 key split notification balance display - #1267
Merged
Chucks1093 merged 2 commits intoOct 22, 2026
Merged
Chucks1093 merged 2 commits into
Chucks1093 merged 2 commits into
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1151
SplitExecutedsocket events, calculate balances accurately, auto-expire banners/badges after 48 hours, and immediately invalidate/refetch wallet holdings upon split execution.sessionStorageso closing the banner clears it for the remainder of the session.Testing
pnpm lint(0 errors, 0 warnings)pnpm build(tsc -b && vite buildsucceeded)pnpm vitest run src/utils/__tests__/keySplit.utils.test.ts(22 passing tests)pnpm vitest run src/components/common/__tests__/SplitAppliedBadge.test.tsx(2 passing tests)pnpm vitest run src/components/common/__tests__/KeySplitBanner.test.tsx(4 passing tests)pnpm vitest run src/hooks/__tests__/useKeySplit.test.tsx(5 passing tests)pnpm vitest run src/pages/__tests__/CreatorDetailPage.keySplit.integration.test.tsx(4 passing tests)pnpm vitest run src/pages/__tests__/WalletPortfolioPage.keySplit.integration.test.tsx(3 passing tests)pnpm vitest run src/pages/__tests__/WalletPortfolioPage.test.tsx(6 passing tests)Checklist