Repository navigation
feat: add per-key price floor to block sells below minimum bonding curve price - #1207
Open
YoungBoss04 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a per-key price floor to the bonding curve so that sell swaps are rejected when the current price is at or below a configured minimum. Buys are unaffected. Admins can set and read the floor per key, and blocked sells surface a dedicated error and event.
Related Issue
Closes #[ISSUE_NUMBER]
Changes
🛡️ Price Floor Enforcement
[MODIFY]
creator-keys/src/curve_subscriptions_swaps.rsset_price_floor(key_id, floor_price)— admin-only; stores the floor for a single key.get_price_floor(key_id)— returns the configured floor, or zero if none is set.swap()with direction=sell now compares the current curve price against the key's floor before executing; if price ≤ floor, the swap is rejected withPriceFloorBreachedcarrying the current price and floor.[MODIFY]
creator-keys/src/events.rsPriceFloorTriggeredevent emitted on every blocked sell, containing the key, attempted price, and floor.Verification Results
No test files were added or modified in this PR; verification should be performed by the reviewer against the acceptance criteria below.
swap()sell path,price <= floorrejectsCloses #1097